Skip to content

Remove unused nonlocal declarations from checkpoint and library helper functions #155686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove unused nonlocal declarations from checkpoint and library helper functions #155686

wants to merge 1 commit into from

Conversation

KAVYANSHTYAGI
Copy link

Description

Cleans up unused nonlocal declarations in _infer_device_type and get_device_states within torch/utils/checkpoint.py.

Drops unused nonlocal op in the register function in torch/library.py.

These changes have no effect on runtime behavior and improve code clarity.

Testing

Verified both files compile with python -m py_compile.

No logic was altered; only redundant code was removed.

If anything needs more detail, happy to update!

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 11, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155686

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit e9af445 with merge base 8153340 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@Skylion007 Skylion007 added the topic: not user facing topic category label Jun 11, 2025
@github-actions GitHub Actions
Copy link
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Aug 10, 2025
@cyyever
Copy link
Collaborator

cyyever commented Aug 11, 2025

@pytorchmergebot merge -r

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 11, 2025
@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased codex/find-undetected-impactful-issue-to-solve onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout codex/find-undetected-impactful-issue-to-solve && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the codex/find-undetected-impactful-issue-to-solve branch from e9af445 to 2727446 Compare August 11, 2025 09:05
@pytorch-bot pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label Aug 11, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 3 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

Assignees
No one assigned
Labels
open source Stale topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KAVYANSHTYAGI @cyyever @pytorchmergebot @Skylion007 @pytorchbot