Skip to content

[MPS] Add regression test for memory leak in nn.MaxPool2d #155730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[MPS] Add regression test for memory leak in nn.MaxPool2d #155730

wants to merge 1 commit into from

Conversation

hvaara
Copy link
Contributor

@hvaara hvaara commented Jun 11, 2025

This PR was previously proposed in #132408 before the fix had landed in MPS. @skotapati confirmed the fix was released in macOS 15.4 in #125217 (comment).

Fixes #125217

@hvaara hvaara requested review from kulinseth and malfet as code owners June 11, 2025 19:57
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 11, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155730

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 3 Cancelled Jobs, 1 Unrelated Failure

As of commit 8246e3c with merge base 79aef14 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jun 11, 2025
@hvaara hvaara mentioned this pull request Jun 11, 2025
Closed
@skotapati skotapati added the ciflow/mps Run MPS tests (subset of trunk) label Jun 11, 2025
@hvaara
Copy link
Contributor Author

hvaara commented Jun 11, 2025

Based on ci signals the issue seems to be present in macOS 13.2.1 and 14.4.1, but looks like it's fixed in macOS 15.2 (unexpected success in the macos-py3-arm64-mps / test (test_mps, 1, 1, macos-m2-15) runner).

@skotapati is it possible the issue was fixed in macOS 15.2 or even earlier?

@github-actions GitHub Actions
Copy link
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth kulinseth is a code owner

@malfet malfet Awaiting requested review from malfet malfet is a code owner

Assignees
No one assigned
Labels
ciflow/mps Run MPS tests (subset of trunk) open source Stale topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MaxPool2D memory leakage on device MPS
4 participants
@hvaara @Skylion007 @skotapati @pytorchbot