[CD] Windows Magma build 12.9 and cuda scripts #155799
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155799
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 14 Pending, 1 Unrelated FailureAs of commit 868acf2 with merge base d632cf2 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| @@ -35,15 +35,15 @@ cd magma | |||
| mkdir build && cd build | |||
|
|
|||
| set GPU_TARGET=All | |||
| if "%CUVER_NODOT%" == "129" ( | |||
| set CUDA_ARCH_LIST=-gencode=arch=compute_75,code=sm_75 -gencode arch=compute_80,code=sm_80 -gencode arch=compute_86,code=sm_86 -gencode arch=compute_90,code=sm_90 -gencode arch=compute_100,code=sm_100 -gencode arch=compute_120,code=sm_120 | |||
| ) | |||
| if "%CUVER_NODOT%" == "128" ( | |||
| set CUDA_ARCH_LIST=-gencode arch=compute_50,code=sm_50 -gencode arch=compute_60,code=sm_60 -gencode arch=compute_70,code=sm_70 -gencode arch=compute_80,code=sm_80 -gencode arch=compute_86,code=sm_86 -gencode arch=compute_90,code=sm_90 -gencode arch=compute_100,code=sm_100 -gencode arch=compute_120,code=sm_120 | |||
There was a problem hiding this comment.
Is this a bug in Magma Windows no sm75 arch for 12.8, 12.6 cuda ?
There was a problem hiding this comment.
Looks like it to me, unless it makes the library too large to link against.
There was a problem hiding this comment.
Thanks for finding the issue. I believe we can remove sm_50-70, and keep sm_75 for CUDA 12.8 and 12.9. For CUDA 12.6, add back sm_75. Linux builds are following the above rules for compute archs.
There was a problem hiding this comment.
FYI - sm_50 to sm_70 will be deprecated in the next major release. "Maxwell, Pascal, and Volta architectures are now feature-complete with no further enhancements planned. While CUDA Toolkit 12.x series will continue to support building applications for these architectures, offline compilation and library support will be removed in the next major CUDA Toolkit version release." https://docs.nvidia.com/cuda/cuda-toolkit-release-notes/index.html
You mean use powerscript instead? Normally I'd agree but this is just keeping it inline with the existing build scripts that already exist. Otherwise, the magma 12.9 build scripts would look totally different from the other magma build scripts. |
|
Removed cuda129.bat file |
This reverts commit 8f8c285.
| @@ -35,15 +35,15 @@ cd magma | |||
| mkdir build && cd build | |||
|
|
|||
| set GPU_TARGET=All | |||
| if "%CUVER_NODOT%" == "129" ( | |||
There was a problem hiding this comment.
so we could condense 128 and 129 into one>> if "%CUVER_NODOT%" == "129" or "%CUVER_NODOT%" == "128"
There was a problem hiding this comment.
We are looking probably to get rid of the batch scripts completely in #155807
|
Landing this PR and will help on landing #155807 as a follwup |
|
@pytorchmergebot merge -f "landing to unblock AMI testing, lint and Magma Builds are green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Scripts needed to build Magma and CUDA on windows Same as pytorch#146653 Pull Request resolved: pytorch#155799 Approved by: https://github.com/jeanschmidt
Scripts needed to build Magma and CUDA on windows
Same as #146653