Skip to content

[CD] Move build_magma.bat to build_magma.py #155804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: gh/malfet/396/base
Choose a base branch
from
Open

[CD] Move build_magma.bat to build_magma.py #155804

wants to merge 1 commit into from

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Jun 12, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Using Claude.ai as transpiler

@malfet
Update
44ae09b 
[ghstack-poisoned]
@malfet malfet requested a review from a team as a code owner June 12, 2025 15:10
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 12, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155804

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 44ae09b with merge base 2a3b41c (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

malfet added a commit that referenced this pull request Jun 12, 2025
@malfet
[CD] Move build_magma.bat to build_magma.py
4e389ff 
Using Claude.ai as transpiler

ghstack-source-id: 4ba2b95
Pull Request resolved: #155804
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jun 12, 2025
@atalman
Copy link
Contributor

atalman commented Jun 12, 2025 •
edited
Loading

Sounds good. As per our conversation lets land just magma part : #155799 here, test it in canary, bring new AMI and then land this refactor PR

Skylion007
Skylion007 reviewed Jun 12, 2025
View reviewed changes
.github/scripts/windows/build_magma.py
Comment on lines +44 to +45
with urllib.request.urlopen(ninja_url, context=ssl_context) as response:
with open(ninja_path, 'wb') as out_file:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these two with estatements could be merged nicely

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ninja could already be installed, and you could just use ninja pip install if we are doing this...

@github-actions GitHub Actions
Copy link
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 left review comments

Assignees
No one assigned
Labels
Stale topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@malfet @atalman @Skylion007