-
Notifications
You must be signed in to change notification settings - Fork 24.9k
[dynamo] Add -> bool to functions named (_?)(is|has)_.* #155923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rec
wants to merge
18
commits into
gh/rec/153/base
Choose a base branch
from
gh/rec/153/head
base: gh/rec/153/base
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+94
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155923
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New Failures, 1 Unrelated FailureAs of commit b2560f8 with merge base ff0d56d ( NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
rec
added a commit
that referenced
this pull request
Jun 13, 2025
See https://github.com/rec/test/blob/master/python/add_bool.py ghstack-source-id: 2108704 Pull Request resolved: #155923
Skylion007
reviewed
Jun 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using typing_extensions here to improve typing
Skylion007
reviewed
Jun 13, 2025
rec
added a commit
that referenced
this pull request
Jun 16, 2025
See https://github.com/rec/test/blob/master/python/add_bool.py ghstack-source-id: e1f0885 Pull Request resolved: #155923
rec
added a commit
that referenced
this pull request
Aug 11, 2025
See https://github.com/rec/test/blob/master/python/add_bool.py ghstack-source-id: e446a61 Pull Request resolved: #155923
rec
added a commit
that referenced
this pull request
Aug 11, 2025
See https://github.com/rec/test/blob/master/python/add_bool.py ghstack-source-id: d994ebf Pull Request resolved: #155923
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
better-engineering
Relatively self-contained tasks for better engineering contributors
ciflow/h100-symm-mem
ciflow/inductor
ciflow/mps
Run MPS tests (subset of trunk)
module: compiled autograd
compiled_autograd
module: cpu
CPU specific problem (e.g., perf, algorithm)
module: dynamo
module: inductor
module: typing
Related to mypy type annotations
oncall: distributed
Add this issue/PR to distributed oncall triage queue
open source
release notes: distributed (checkpoint)
release notes: inductor (aoti)
release notes: quantization
release notes category
topic: not user facing
topic category
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
See https://github.com/rec/test/blob/master/python/add_bool.py
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @jerryzh168 @ezyang @malfet @xuzhao9 @gramster @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @Lucaskabela @xmfan