[inductor] Add return types to functions named (_?)(is|has)_.* #155928

rec · 2025-06-13T17:22:20Z

Stack from ghstack (oldest at bottom):

-> [inductor] Add return types to functions named (_?)(is|has)_.* #155928

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd @ezyang @malfet @xuzhao9 @gramster @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov

[ghstack-poisoned]

pytorch-bot · 2025-06-13T17:22:23Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155928

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 7de7764 with merge base ff0d56d ():

NEW FAILURE - The following job has failed:

Lint / lintrunner-mypy / linux-job (gh)
>>> Lint for torch/_inductor/fx_passes/quantization.py:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]

ghstack-source-id: bd972f2 Pull Request resolved: #155928

ezyang · 2025-06-14T02:48:29Z

unsubbing as it is not correct

rec · 2025-06-14T13:30:45Z

Ah, sorry, @ezyang, I left it in draft, this was just to see how well an automatic script could do this... though I intend to clean it up and send it for review.

torch/_inductor/codegen/cuda/cutlass_utils.py

Skylion007 · 2025-06-14T18:40:47Z

torch/_inductor/codegen/rocm/ck_tile_universal_gemm_template.py

@@ -19,7 +19,7 @@
 log = logging.getLogger(__name__)


-def is_static_int(number):
+def is_static_int(number) -> bool:


same as above

torch/_inductor/codegen/rocm/ck_universal_gemm_template.py

torch/_inductor/ir.py

Skylion007 · 2025-06-14T18:42:05Z

torch/_inductor/lowering.py

@@ -1592,7 +1592,7 @@ def unwrap_tensor(x: Union[TensorBox, ir.StorageBox]) -> ir.IRNode:

        return x

-    def is_reduction(t):
+    def is_reduction(t) -> bool:


Suggested change

def is_reduction(t) -> bool:

def is_reduction(t) -> TypeGuard[ir.ComputedBuffer]:

[ghstack-poisoned]

rec · 2025-06-15T19:03:07Z

@Skylion007 Took every suggestion!

[ghstack-poisoned]

ghstack-source-id: 1cd98b8 Pull Request resolved: #155928

[ghstack-poisoned]

ghstack-source-id: 085071d Pull Request resolved: #155928

[ghstack-poisoned]

ghstack-source-id: 910968f Pull Request resolved: #155928

rec · 2025-07-04T17:18:56Z

@Skylion007 Updated!

[ghstack-poisoned]

ghstack-source-id: 2e7be20 Pull Request resolved: #155928

[ghstack-poisoned]

ghstack-source-id: 20a6ab6 Pull Request resolved: #155928

rec · 2025-07-30T09:34:01Z

@pytorchbot rebase

pytorchmergebot · 2025-07-30T09:35:32Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

[ghstack-poisoned]

pytorchmergebot · 2025-07-30T09:35:44Z

Successfully rebased gh/rec/154/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/155928)

ghstack-source-id: 6262915 Pull Request resolved: #155928

[ghstack-poisoned]

ghstack-source-id: 93ae2fc Pull Request resolved: #155928

rec · 2025-08-05T12:35:46Z

@pytorchbot rebase

pytorchmergebot · 2025-08-05T12:37:15Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2025-08-05T12:37:20Z

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict gh/rec/154/orig returned non-zero exit code 1

Rebasing (1/1)
Auto-merging torch/_inductor/codegen/cpp.py
Auto-merging torch/_inductor/codegen/simd.py
Auto-merging torch/_inductor/codegen/triton.py
Auto-merging torch/_inductor/codegen/wrapper.py
Auto-merging torch/_inductor/fx_passes/post_grad.py
Auto-merging torch/_inductor/kernel/flex/flex_attention.py
CONFLICT (content): Merge conflict in torch/_inductor/kernel/flex/flex_attention.py
Auto-merging torch/_inductor/kernel/mm.py
Auto-merging torch/_inductor/lowering.py
Auto-merging torch/_inductor/runtime/triton_helpers.py
Auto-merging torch/_inductor/runtime/triton_heuristics.py
error: could not apply 26f30848892... [inductor] Add return types to functions named (_?)(is|has)_.*
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Could not apply 26f30848892... # [inductor] Add return types to functions named (_?)(is|has)_.*

Raised by https://github.com/pytorch/pytorch/actions/runs/16750203924

[ghstack-poisoned]

ghstack-source-id: ccbb30d Pull Request resolved: #155928

[ghstack-poisoned]

ghstack-source-id: b7830e4 Pull Request resolved: #155928

[ghstack-poisoned]

ghstack-source-id: 1f7d1b5 Pull Request resolved: #155928

Update

ed111e6

[ghstack-poisoned]

pytorch-bot bot added ciflow/inductor module: inductor labels Jun 13, 2025

facebook-github-bot added the module: rocm AMD GPU support for Pytorch label Jun 13, 2025

rec added module: typing Related to mypy type annotations better-engineering Relatively self-contained tasks for better engineering contributors topic: not user facing topic category labels Jun 13, 2025

pytorchbot added the open source label Jun 13, 2025

Update

bd62251

[ghstack-poisoned]

Update

04ac778

[ghstack-poisoned]

rec added a commit that referenced this pull request Jun 13, 2025

[inductor] Add -> bool to functions named is_* or _is_*

30bebf5

ghstack-source-id: bd972f2 Pull Request resolved: #155928

Skylion007 reviewed Jun 14, 2025

View reviewed changes

Update

4ebc169

[ghstack-poisoned]

Update

5bac394

[ghstack-poisoned]

Update

8a34309

[ghstack-poisoned]

rec added a commit that referenced this pull request Jun 16, 2025

[inductor] Add -> bool to functions named is_* or _is_*

dfad851

ghstack-source-id: 1cd98b8 Pull Request resolved: #155928

Update

a9529ea

[ghstack-poisoned]

rec added a commit that referenced this pull request Jun 16, 2025

[inductor] Add -> bool to functions named is_* or _is_*

c8d6750

ghstack-source-id: 085071d Pull Request resolved: #155928

Update

fdf5442

[ghstack-poisoned]

rec added a commit that referenced this pull request Jun 17, 2025

[inductor] Add -> bool to functions named is_* or _is_*

67963ae

ghstack-source-id: 910968f Pull Request resolved: #155928

rec marked this pull request as ready for review June 17, 2025 13:57

Update

b1b6113

[ghstack-poisoned]

rec added a commit that referenced this pull request Jul 29, 2025

[inductor] Add return types to functions named (_?)(is|has)_.*

c0e3f89

ghstack-source-id: 2e7be20 Pull Request resolved: #155928

Update

d080027

[ghstack-poisoned]

rec changed the title ~~[inductor] Add -> bool to functions named is_* or _is_*~~ [inductor] Add return types to functions named (_?)(is|has)_.* Jul 29, 2025

rec added a commit that referenced this pull request Jul 29, 2025

[inductor] Add return types to functions named (_?)(is|has)_.*

5daf8c3

ghstack-source-id: 20a6ab6 Pull Request resolved: #155928

Update

da21cc9

[ghstack-poisoned]

pytorchmergebot pushed a commit that referenced this pull request Jul 30, 2025

[inductor] Add return types to functions named (_?)(is|has)_.*

fcf1abc

ghstack-source-id: 6262915 Pull Request resolved: #155928

Update

728336f

[ghstack-poisoned]

rec added a commit that referenced this pull request Jul 30, 2025

[inductor] Add return types to functions named (_?)(is|has)_.*

26f3084

ghstack-source-id: 93ae2fc Pull Request resolved: #155928

Update

2244efa

[ghstack-poisoned]

rec added a commit that referenced this pull request Aug 5, 2025

[inductor] Add return types to functions named (_?)(is|has)_.*

acd83d2

ghstack-source-id: ccbb30d Pull Request resolved: #155928

Update

7055ebb

[ghstack-poisoned]

rec added a commit that referenced this pull request Aug 6, 2025

[inductor] Add return types to functions named (_?)(is|has)_.*

c71f1b4

ghstack-source-id: b7830e4 Pull Request resolved: #155928

Update

7de7764

[ghstack-poisoned]

rec added a commit that referenced this pull request Aug 11, 2025

[inductor] Add return types to functions named (_?)(is|has)_.*

55f101f

ghstack-source-id: 1f7d1b5 Pull Request resolved: #155928

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[inductor] Add return types to functions named (_?)(is|has)_.* #155928

[inductor] Add return types to functions named (_?)(is|has)_.* #155928

Uh oh!

rec commented Jun 13, 2025 •

edited by pytorch-bot bot

Loading

Uh oh!

pytorch-bot bot commented Jun 13, 2025 •

edited

Loading

Uh oh!

ezyang commented Jun 14, 2025

Uh oh!

rec commented Jun 14, 2025

Uh oh!

Uh oh!

Skylion007 Jun 14, 2025

Uh oh!

Uh oh!

Uh oh!

Skylion007 Jun 14, 2025

Uh oh!

rec commented Jun 15, 2025

Uh oh!

rec commented Jul 4, 2025

Uh oh!

rec commented Jul 30, 2025

Uh oh!

pytorchmergebot commented Jul 30, 2025

Uh oh!

pytorchmergebot commented Jul 30, 2025

Uh oh!

rec commented Aug 5, 2025

Uh oh!

pytorchmergebot commented Aug 5, 2025

Uh oh!

pytorchmergebot commented Aug 5, 2025

Uh oh!

Uh oh!

	def is_reduction(t) -> bool:
	def is_reduction(t) -> TypeGuard[ir.ComputedBuffer]:

[inductor] Add return types to functions named (_?)(is|has)_.* #155928

Are you sure you want to change the base?

[inductor] Add return types to functions named (_?)(is|has)_.* #155928

Uh oh!

Conversation

rec commented Jun 13, 2025 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155928

❌ 1 New Failure

Uh oh!

ezyang commented Jun 14, 2025

Uh oh!

rec commented Jun 14, 2025

Uh oh!

Uh oh!

Skylion007 Jun 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Skylion007 Jun 14, 2025

Choose a reason for hiding this comment

Uh oh!

rec commented Jun 15, 2025

Uh oh!

rec commented Jul 4, 2025

Uh oh!

rec commented Jul 30, 2025

Uh oh!

pytorchmergebot commented Jul 30, 2025

Uh oh!

pytorchmergebot commented Jul 30, 2025

Uh oh!

rec commented Aug 5, 2025

Uh oh!

pytorchmergebot commented Aug 5, 2025

Uh oh!

pytorchmergebot commented Aug 5, 2025

Uh oh!

Uh oh!

rec commented Jun 13, 2025 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Jun 13, 2025 •

edited

Loading