Skip to content

[BE][Easy] set end-of-line for .bat file to CRLF in .editorconfig #156032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[BE][Easy] set end-of-line for .bat file to CRLF in .editorconfig #156032

wants to merge 2 commits into from

Conversation

XuehaiPan
Copy link
Collaborator

@XuehaiPan XuehaiPan commented Jun 15, 2025 •
edited
Loading

@XuehaiPan
Update
b403fdd 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 15, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156032

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job, 1 Pending

As of commit 97fcc14 with merge base 2022588 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

XuehaiPan added a commit that referenced this pull request Jun 15, 2025
@XuehaiPan
[BE][Easy] set end-of-line for .bat file to CRLF in .editorconfig
347ae25 
See also:

https://github.com/pytorch/pytorch/blob/54976bca103fcf2b5037cc0cd1b37c4639fcf779/.gitattributes#L1
ghstack-source-id: d1ee80a
Pull-Request: #156032
@XuehaiPan XuehaiPan added better-engineering Relatively self-contained tasks for better engineering contributors topic: not user facing topic category labels Jun 15, 2025
@XuehaiPan XuehaiPan requested a review from malfet June 18, 2025 17:15
@XuehaiPan
Update
97fcc14 
[ghstack-poisoned]
This was referenced Jul 7, 2025
Open
Open
Open
Open
Open
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 7, 2025
@XuehaiPan
[BE][Easy] set end-of-line for .bat file to CRLF in .editorconfig
e4c0854 
See also:

https://github.com/pytorch/pytorch/blob/54976bca103fcf2b5037cc0cd1b37c4639fcf779/.gitattributes#L1
ghstack-source-id: 18c4c18
Pull-Request: pytorch#156032
@XuehaiPan XuehaiPan requested a review from ezyang July 7, 2025 05:40
@ezyang
Copy link
Contributor

ezyang commented Jul 8, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 8, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-jammy-rocm-py3.10 / test (default, 1, 2, linux.rocm.gpu.2)

Details for Dev Infra team Raised by workflow job

@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge -f "no need to want for ci"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/XuehaiPan/284/head branch August 8, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

@seemethere seemethere seemethere approved these changes

@malfet malfet Awaiting requested review from malfet

Assignees
No one assigned
Labels
better-engineering Relatively self-contained tasks for better engineering contributors ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@XuehaiPan @ezyang @pytorchmergebot @seemethere @pytorchbot