Skip to content

Install nvperf_host together with cupti #156668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Jun 24, 2025

Because cupti depends on nvperf_host, as discussed in #154595

@cyyever cyyever requested a review from a team as a code owner June 24, 2025 01:37
Copy link

pytorch-bot bot commented Jun 24, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156668

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 2 Pending, 1 Unrelated Failure

As of commit 4ed1452 with merge base 1d993fa (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever
Copy link
Collaborator Author

cyyever commented Jun 24, 2025

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jun 24, 2025
@cyyever cyyever changed the title Install nvperf_host togather with cupti Install nvperf_host together with cupti Jun 24, 2025
@@ -149,6 +151,8 @@ if [[ $CUDA_VERSION == 12* ]]; then
"libnvrtc-builtins.so"
"libcufile.so.0"
"libcufile_rdma.so.1"
"libcupti.so.12"
"libnvperf_host.so"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need rpath edits like below for pypi? Also, why isn't this included with the pypi wheel to keep our binary size down? https://pypi.org/project/nvidia-cuda-cupti-cu12/

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cyyever, Yeah: confirmed that

  • nvidia/cuda_cupti/lib/libcheckpoint.so
  • nvidia/cuda_cupti/lib/libcupti.so.12
  • nvidia/cuda_cupti/lib/libnvperf_host.so
  • nvidia/cuda_cupti/lib/libnvperf_target.so
  • nvidia/cuda_cupti/lib/libpcsamplingutil.so

are all in the wheel

@ptrblck
Copy link
Collaborator

ptrblck commented Jun 25, 2025

Unclear why we would need a new lib after #154595. Cross-posting: #154595 (comment)

@cyyever
Copy link
Collaborator Author

cyyever commented Jun 25, 2025

@ptrblck Because that PR is too large to review. I extract some parts of it to verify.

@mikaylagawarecki mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 26, 2025
@mikaylagawarecki mikaylagawarecki requested a review from malfet June 26, 2025 16:02
@cyyever
Copy link
Collaborator Author

cyyever commented Jun 27, 2025

@pytorchmergebot merge -i

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 27, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: pull / cuda12.8-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu, unstable)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever
Copy link
Collaborator Author

cyyever commented Jun 28, 2025

@pytorchbot merge -f "ROCm pending"

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants