-
Notifications
You must be signed in to change notification settings - Fork 24.9k
Install nvperf_host together with cupti #156668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156668
Note: Links to docs will display an error until the docs builds have been completed. ⏳ 2 Pending, 1 Unrelated FailureAs of commit 4ed1452 with merge base 1d993fa ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot label "topic: not user facing" |
@@ -149,6 +151,8 @@ if [[ $CUDA_VERSION == 12* ]]; then | |||
"libnvrtc-builtins.so" | |||
"libcufile.so.0" | |||
"libcufile_rdma.so.1" | |||
"libcupti.so.12" | |||
"libnvperf_host.so" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need rpath edits like below for pypi? Also, why isn't this included with the pypi wheel to keep our binary size down? https://pypi.org/project/nvidia-cuda-cupti-cu12/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cyyever, Yeah: confirmed that
- nvidia/cuda_cupti/lib/libcheckpoint.so
- nvidia/cuda_cupti/lib/libcupti.so.12
- nvidia/cuda_cupti/lib/libnvperf_host.so
- nvidia/cuda_cupti/lib/libnvperf_target.so
- nvidia/cuda_cupti/lib/libpcsamplingutil.so
are all in the wheel
Unclear why we would need a new lib after #154595. Cross-posting: #154595 (comment) |
@ptrblck Because that PR is too large to review. I extract some parts of it to verify. |
@pytorchmergebot merge -i |
Merge startedYour change will be merged while ignoring the following 1 checks: pull / cuda12.8-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu, unstable) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
@pytorchbot merge -f "ROCm pending" |
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Because cupti depends on nvperf_host, as discussed in #154595