Add dist_info to non-building setup.py commands #156709
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156709
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 497a24f with merge base d9577df ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| @@ -370,7 +370,7 @@ def _get_package_path(package_name): | |||
| break | |||
| if arg == "-q" or arg == "--quiet": | |||
| VERBOSE_SCRIPT = False | |||
| if arg in ["clean", "egg_info", "sdist"]: | |||
| if arg in ["clean", "dist_info", "egg_info", "sdist"]: | |||
There was a problem hiding this comment.
slight nit:
This command is private and reserved for internal use of setuptools,
users should rely on setuptools.build_meta APIs.
Still though, looks harmless enough.
There was a problem hiding this comment.
slight nit: This command is private and reserved for internal use of setuptools, users should rely on
setuptools.build_metaAPIs.Still though, looks harmless enough.
This is true, but also exactly how I came across it: When doing something like pip install -C---build-option=--cmake-only , immediately a full build is kicked off. This happens because setuptools calls first dist_info and then build, but passes the build options only to build. One can discuss whether that's a problem in between pip and setuptools, but ultimately it makes sense to me that dist_info doesn't do a build, right?
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
ghstack-source-id: 98c5716 Pull Request resolved: pytorch#156709
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This adds the
dist_infocommand to the list of non-building commands ofsetup.py, which avoids the current situation where simple metadata generation with any packaging tool already triggers a build.Stack from ghstack (oldest at bottom):