-
Notifications
You must be signed in to change notification settings - Fork 24.9k
[BE] add type annotations and run mypy
on setup.py
#156741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156741
Note: Links to docs will display an error until the docs builds have been completed. ⏳ 5 Pending, 1 Unrelated FailureAs of commit 10a1fae with merge base c202a73 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ghstack-source-id: 6ce9c20 Pull-Request: pytorch#156741
ghstack-source-id: e7c0c53 Pull-Request: pytorch#156741
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_13t-rocm6_4-build / build Details for Dev Infra teamRaised by workflow job |
ghstack-source-id: 469a826 Pull-Request: pytorch#156741
ghstack-source-id: cc61a1a Pull-Request: pytorch#156741
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
@pytorchbot merge -f "long s390x ci queue" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
@XuehaiPan For the future you should probably use "-i" instead of "-f" because it will only ignore the things that are currently pending instead of forcing all future jobs. |
…`setup.py` (#156044) Pull Request resolved: #156044 Approved by: https://github.com/albanD ghstack dependencies: #156741
Stack from ghstack (oldest at bottom):
setuptools<80.0
#156049python setup.py develop/install
->[uv ]pip install --no-build-isolation [-e ].
#156027pyproject.toml
consistency #156017setuptools.build_meta:__legacy__
->setuptools.build_meta
#155998pathlib.Path
instead ofos.path.*
insetup.py
#156742super().method(...)
in command subclasses insetup.py
#156044mypy
onsetup.py
#156741