[BE] use pathlib.Path instead of os.path.* in setup.py
#156742
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156742
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit e456a3e with merge base 3df6360 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jun 24, 2025
Closed
Closed
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jun 24, 2025
ghstack-source-id: 887e52b Pull-Request: pytorch#156742
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 1, 2025
ghstack-source-id: 0570a19 Pull-Request: pytorch#156742
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 1, 2025
ghstack-source-id: 5396e3a Pull-Request: pytorch#156742
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 1, 2025
ghstack-source-id: 9bb12c6 Pull-Request: pytorch#156742
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 1, 2025
ghstack-source-id: 9bb12c6 Pull-Request: pytorch#156742
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 1, 2025
ghstack-source-id: b3766a3 Pull-Request: pytorch#156742
XuehaiPan
commented
Jul 1, 2025
Comment on lines
+1336
to
+1342
| # XXX: Why not use wildcards ["lib/aotriton.images/*", "lib/aotriton.images/**/*"] here? | ||
| aotriton_image_path = TORCH_DIR / "lib" / "aotriton.images" | ||
| aks2_files = [ | ||
| file.relative_to(TORCH_DIR).as_posix() | ||
| for file in aotriton_image_path.rglob("*") | ||
| if file.is_file() | ||
| ] |
There was a problem hiding this comment.
The previous code gets aks2_files = [] and breaks the ROCm build on trunk. I'm not sure why.
I think the following code seems equivalent.
aotriton_image_path = TORCH_DIR / "lib" / "aotriton.images"
- aks2_files: list[str] = []
- for file in filter(lambda p: p.is_file(), aotriton_image_path.glob("**")):
- subpath = file.relative_to(aotriton_image_path)
- aks2_files.append(os.path.join("lib/aotriton.images", subpath))
+ aks2_files = [
+ file.relative_to(TORCH_DIR).as_posix()
+ for file in aotriton_image_path.rglob("*")
+ if file.is_file()
+ ]PS: path.rglob("*") is equivalent to path.glob("**/*"). path.glob("**") will yield path while path.glob("**/*") will not. But we are looking for files only, so they are the same.
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 1, 2025
ghstack-source-id: b3766a3 Pull-Request: pytorch#156742
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 1, 2025
ghstack-source-id: b3766a3 Pull-Request: pytorch#156742
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 2, 2025
ghstack-source-id: 0a78781 Pull-Request: pytorch#156742
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 2, 2025
ghstack-source-id: 0a78781 Pull-Request: pytorch#156742
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 2, 2025
ghstack-source-id: 0a78781 Pull-Request: pytorch#156742
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 2, 2025
ghstack-source-id: 0a78781 Pull-Request: pytorch#156742
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 2, 2025
ghstack-source-id: 0a78781 Pull-Request: pytorch#156742
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 2, 2025
ghstack-source-id: 0a78781 Pull-Request: pytorch#156742
malfet
approved these changes
Jul 2, 2025
|
@pytorchbot merge -f "All relevant tests are green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Jul 2, 2025
…56958) See also: - astral-sh/uv#14269 Pull Request resolved: #156958 Approved by: https://github.com/Skylion007 ghstack dependencies: #156742
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves:
setuptools.build_meta:__legacy__->setuptools.build_meta#155998 (comment)Stack from ghstack (oldest at bottom):
setuptools<80.0#156049python setup.py develop/install->[uv ]pip install --no-build-isolation [-e ].#156027pyproject.tomlconsistency #156017setuptools.build_meta:__legacy__->setuptools.build_meta#155998pathlib.Pathinstead ofos.path.*insetup.py#156742