Skip to content

Introduce a new API torch.accelerator.get_mem_info #156812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 23 commits into
base: gh/guangyey/163/base
Choose a base branch
from
Open

Introduce a new API torch.accelerator.get_mem_info #156812

wants to merge 23 commits into from
+81 −22

Conversation

guangyey
Copy link
Collaborator

@guangyey guangyey commented Jun 25, 2025 •
edited
Loading

@guangyey guangyey requested review from eqy and syed-ahmed as code owners June 25, 2025 11:18
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 25, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156812

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 16 Pending

As of commit e19a8fc with merge base a354fa9 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Jun 25, 2025
Closed
Closed
Closed
Draft
@guangyey guangyey changed the title Introduce a new API torch.accelerator.get_mem_info [WIP] Introduce a new API torch.accelerator.get_mem_info Jun 25, 2025
guangyey added 4 commits June 25, 2025 18:48
@guangyey
Update
95d0309 
[ghstack-poisoned]
@guangyey
Update
ed3f309 
[ghstack-poisoned]
@guangyey
Update
db70a7e 
[ghstack-poisoned]
@guangyey
Update
4088c18 
[ghstack-poisoned]
@guangyey guangyey added the release notes: python_frontend python frontend release notes category label Jul 7, 2025
@guangyey guangyey changed the title [WIP] Introduce a new API torch.accelerator.get_mem_info Introduce a new API torch.accelerator.get_mem_info Jul 7, 2025
guangyey added 2 commits July 7, 2025 16:13
@guangyey
Update
31b9279 
[ghstack-poisoned]
@guangyey
Update
6d7cc6d 
[ghstack-poisoned]
@guangyey guangyey added the ciflow/xpu Run XPU CI tasks label Jul 8, 2025
guangyey added 8 commits July 8, 2025 16:22
@guangyey
Update
109f798 
[ghstack-poisoned]
@guangyey
Update
e9467fb 
[ghstack-poisoned]
@guangyey
Update
3cd42a4 
[ghstack-poisoned]
@guangyey
Update
c9f6133 
[ghstack-poisoned]
@guangyey
Update
bfe9db9 
[ghstack-poisoned]
@guangyey
Update
4e7474b 
[ghstack-poisoned]
@guangyey
Update
d950af0 
[ghstack-poisoned]
@guangyey
Update
87ad13f 
[ghstack-poisoned]
@guangyey
Update
ecfd210 
[ghstack-poisoned]
@guangyey guangyey requested a review from albanD July 21, 2025 02:33
@guangyey
Update
acd57ab 
[ghstack-poisoned]
@albanD
Copy link
Collaborator

albanD commented Jul 21, 2025

Isn't this duplicated with other existing APIs?

@guangyey
Copy link
Collaborator Author

Unlike torch.accelerator.memory_stats family of APIs, which only collects memory statistics for the current process, torch.accelerator.get_memory_info reports a (free, total) pair for the current device. The reported free memory reflects usage across all processes, not just the current one.

guangyey added 2 commits July 22, 2025 09:55
@guangyey
Update
6c537c7 
[ghstack-poisoned]
@guangyey
Update
1e09ac1 
[ghstack-poisoned]
@Stonepia
Copy link
Contributor

Currently, in transformers code, there are CUDA hard-coded place like below:

        if device.type == "cuda":
            index = device.index if device.index is not None else torch.cuda.current_device()
            device_memory = torch.cuda.mem_get_info(index)[0]

Changing these code with another if xpu ... with the same logic would be too ugly, so if we have this unified API would be great.

@Stonepia Stonepia mentioned this pull request Jul 24, 2025
Closed
guangyey added 2 commits August 1, 2025 21:49
@guangyey
Update
3485cfe 
[ghstack-poisoned]
@guangyey
Update
3ed6a5e 
[ghstack-poisoned]
@guangyey
Copy link
Collaborator Author

guangyey commented Aug 5, 2025

@albanD Do you think if introducing this API is reasonable.

guangyey added 2 commits August 6, 2025 00:36
@guangyey
Update
bb349e2 
[ghstack-poisoned]
@guangyey
Update
ab5c4b2 
[ghstack-poisoned]
@guangyey
Copy link
Collaborator Author

@albanD Just a kind reminder ^_^
I am not sure which function name is better.
The original function name is torch.xxx.mem_get_info, the name this PR proposed is torch.accelerator.get_memory_info,
I'd appreciate your advice.

@guangyey
Update
e19a8fc 
[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eqy eqy Awaiting requested review from eqy eqy is a code owner

@syed-ahmed syed-ahmed Awaiting requested review from syed-ahmed syed-ahmed is a code owner

@EikanWang EikanWang Awaiting requested review from EikanWang EikanWang is a code owner

@gujinghui gujinghui Awaiting requested review from gujinghui gujinghui is a code owner

@jeffdaily jeffdaily Awaiting requested review from jeffdaily

@jithunnair-amd jithunnair-amd Awaiting requested review from jithunnair-amd

@albanD albanD Awaiting requested review from albanD

Assignees
No one assigned
Labels
ciflow/xpu Run XPU CI tasks open source release notes: python_frontend python frontend release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guangyey @albanD @Stonepia @pytorchbot