Skip to content

[BE] parse CMake version from cmake -E capabilities instead of cmake --version #157073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

[BE] parse CMake version from cmake -E capabilities instead of cmake --version #157073

wants to merge 8 commits into from

Conversation

XuehaiPan
Copy link
Collaborator

@XuehaiPan XuehaiPan commented Jun 27, 2025 •
edited
Loading

cmake -E capabilities produces a JSON format that is more machine-friendly.

$ cmake --version
cmake version 4.0.3

CMake suite maintained and supported by Kitware (kitware.com/cmake).
$ cmake -E capabilities | jq '.version.string'
"4.0.3"
$ cmake -E capabilities | jq
{
  "debugger": true,
  "fileApi": {
    "requests": [
      {
        "kind": "codemodel",
        "version": [
          {
            "major": 2,
            "minor": 8
          }
        ]
      },
      {
        "kind": "configureLog",
        "version": [
          {
            "major": 1,
            "minor": 0
          }
        ]
      },
      {
        "kind": "cache",
        "version": [
          {
            "major": 2,
            "minor": 0
          }
        ]
      },
      {
        "kind": "cmakeFiles",
        "version": [
          {
            "major": 1,
            "minor": 1
          }
        ]
      },
      {
        "kind": "toolchains",
        "version": [
          {
            "major": 1,
            "minor": 0
          }
        ]
      }
    ]
  },
  "generators": [
    {
      "extraGenerators": [],
      "name": "Watcom WMake",
      "platformSupport": false,
      "toolsetSupport": false
    },
    {
      "extraGenerators": [
        "Kate"
      ],
      "name": "Ninja Multi-Config",
      "platformSupport": false,
      "toolsetSupport": false
    },
    {
      "extraGenerators": [
        "CodeBlocks",
        "CodeLite",
        "Eclipse CDT4",
        "Kate",
        "Sublime Text 2"
      ],
      "name": "Ninja",
      "platformSupport": false,
      "toolsetSupport": false
    },
    {
      "extraGenerators": [],
      "name": "Xcode",
      "platformSupport": false,
      "toolsetSupport": true
    },
    {
      "extraGenerators": [
        "CodeBlocks",
        "CodeLite",
        "Eclipse CDT4",
        "Kate",
        "Sublime Text 2"
      ],
      "name": "Unix Makefiles",
      "platformSupport": false,
      "toolsetSupport": false
    }
  ],
  "serverMode": false,
  "tls": true,
  "version": {
    "isDirty": false,
    "major": 4,
    "minor": 0,
    "patch": 3,
    "string": "4.0.3",
    "suffix": ""
  }
}

Stack from ghstack (oldest at bottom):

@XuehaiPan
Update
6d2d8d8 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 27, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157073

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit c6b0f69 with merge base 2eb744c (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jun 27, 2025
This was referenced Jun 27, 2025
Closed
Closed
@XuehaiPan
Update
8515064 
[ghstack-poisoned]
@XuehaiPan XuehaiPan requested review from ezyang and Skylion007 June 27, 2025 07:52
@XuehaiPan XuehaiPan added the better-engineering Relatively self-contained tasks for better engineering contributors label Jun 27, 2025
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jun 27, 2025
@XuehaiPan
[BE] parse CMake version from cmake -E capabilities instead of `cma…
16d4b8d 
…ke --version`

ghstack-source-id: db207d1
Pull-Request: pytorch#157073
@XuehaiPan
Update
8adec7f 
[ghstack-poisoned]
@XuehaiPan
Update
574395d 
[ghstack-poisoned]
@XuehaiPan
Update
3c19432 
[ghstack-poisoned]
@XuehaiPan
Update
8e4aeb0 
[ghstack-poisoned]
@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 28, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

This was referenced Jun 28, 2025
Closed
Closed
Closed
Closed
@XuehaiPan
Copy link
Collaborator Author

@pytorchbot revert -m "break libtorch build on Windows" -c nosignal

@XuehaiPan XuehaiPan added ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR ciflow/binaries_libtorch Trigger binary build and upload jobs for libtorch on the PR labels Jun 28, 2025
@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Jun 28, 2025
@pytorchmergebot
Revert "[BE] parse CMake version from cmake -E capabilities instead…
2eb744c 
… of `cmake --version` (#157073)"

This reverts commit 0c58bdd.

Reverted #157073 on behalf of https://github.com/XuehaiPan due to break libtorch build on Windows ([comment](#157073 (comment)))
@pytorchmergebot
Copy link
Collaborator

@XuehaiPan your PR has been successfully reverted.

@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Jun 28, 2025
@XuehaiPan
Update
dcf6754 
[ghstack-poisoned]
@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 4 jobs have failed, first few of them are: windows-binary-libtorch-release / libtorch-cuda12_6-shared-with-deps-release-build, windows-binary-libtorch-release / libtorch-cuda12_8-shared-with-deps-release-build, windows-binary-libtorch-debug / libtorch-cpu-shared-with-deps-debug-build, windows-binary-libtorch-debug / libtorch-cuda12_9-shared-with-deps-debug-build

Details for Dev Infra team Raised by workflow job

@XuehaiPan
Update
c6b0f69 
[ghstack-poisoned]
@XuehaiPan XuehaiPan requested a review from a team as a code owner June 28, 2025 15:13
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jun 28, 2025
@XuehaiPan
[BE] parse CMake version from cmake -E capabilities instead of `cma…
4ba87ce 
…ke --version`

ghstack-source-id: 21e2048
Pull-Request: pytorch#157073
@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/XuehaiPan/337/head branch July 29, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@ezyang ezyang Awaiting requested review from ezyang

Assignees
No one assigned
Labels
better-engineering Relatively self-contained tasks for better engineering contributors ci-no-td Do not run TD on this PR ciflow/binaries_libtorch Trigger binary build and upload jobs for libtorch on the PR ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged open source Reverted topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XuehaiPan @pytorchmergebot @Skylion007 @pytorchbot