[SymmMem] Install NVSHMEM wheel in CI docker #157411
Open
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skylion007
previously approved these changes
Jul 2, 2025
Skylion007
reviewed
Jul 2, 2025
| @@ -135,3 +135,6 @@ do | |||
| esac | |||
| shift | |||
| done | |||
|
|
|||
| # Install NVSHMEM wheel which is a build-time dependency for torch since 2.8 | |||
| python3 -mpip install nvidia-nvshmem-cu12 | |||
There was a problem hiding this comment.
Interesting, why don't we build it like other nvidia libraries and use the pip bundle instead?
|
Closing in favor of #157453 |
|
@kwen2501 Actually looks like we need more CMake changes are our current build is broken, rip on the older hardware. RIP |
pytorchmergebot
pushed a commit
that referenced
this pull request
Jul 3, 2025
…atest for 2.8RC (#157453) Fixed our bad builds of nvshmem, (we were not building or testing before) and also updates to the latest version. Newest versions has critical support for things that would actually make it useful, like bfloat16 and float16 support. This is a proper fix for: #157411 Pull Request resolved: #157453 Approved by: https://github.com/kwen2501, https://github.com/atalman
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
pytorchbot
pushed a commit
that referenced
this pull request
Jul 8, 2025
…atest for 2.8RC (#157453) Fixed our bad builds of nvshmem, (we were not building or testing before) and also updates to the latest version. Newest versions has critical support for things that would actually make it useful, like bfloat16 and float16 support. This is a proper fix for: #157411 Pull Request resolved: #157453 Approved by: https://github.com/kwen2501, https://github.com/atalman (cherry picked from commit a6fab82)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
2.8 RC1 and nightly build did not compile with NVSHMEM, because the build environment on CI machine does not have NVSHMEM installed.
This PR pip installs NVSHMEM wheel in the docker of CI.
Also add
nvidia-nvshmem-cu12toPYTORCH_EXTRA_INSTALL_REQUIREMENTSof CUDA 12.9.