Skip to content

adding types to nn module init #158065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

adding types to nn module init #158065

wants to merge 4 commits into from
+5 −2

Conversation

Raman-RH
Copy link
Contributor

Fixes #156740

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 10, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158065

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 167fee6 with merge base 8c0c5c5 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@Raman-RH
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jul 10, 2025
Skylion007
Skylion007 reviewed Jul 10, 2025
View reviewed changes
torch/nn/modules/module.py Outdated
@@ -476,7 +475,7 @@ def forward(self, x):
call_super_init: bool = False
_compiled_call_impl: Optional[Callable] = None

def __init__(self, *args, **kwargs) -> None:
def __init__(self, *args: TypeVarTuple, **kwargs: Dict[str, Any]) -> None:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't right, you need to instationate a TypevarTuple as a TypeVar and then use it

@Raman-RH
Copy link
Contributor Author

@Skylion007
changed that please have a look

@albanD albanD removed their request for review July 14, 2025 21:43
@albanD albanD added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jul 14, 2025
@Raman-RH
Copy link
Contributor Author

@albanD @Skylion007 or anyone
please have a look

@albanD
Copy link
Collaborator

albanD commented Jul 29, 2025

Hey!
I'm afraid no one has much bandwidth to review these PRs at the moment. I would suggest waiting for an issue to be marked as actionable before working on it to make sure someone is happy to review the PR.
See https://github.com/pytorch/pytorch/wiki/The-Ultimate-Guide-to-PyTorch-Contributions for details on contributing

@Raman-RH
Copy link
Contributor Author

@pytorchbot retest

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 11, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: 'retest' (choose from 'merge', 'revert', 'rebase', 'label', 'drci', 'cherry-pick')

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick} ...

Try @pytorchbot --help for more info.

@Raman-RH
Copy link
Contributor Author

/retest

@Raman-RH Raman-RH closed this Aug 11, 2025
@Raman-RH Raman-RH reopened this Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 left review comments

@jbschlosser jbschlosser Awaiting requested review from jbschlosser jbschlosser is a code owner

@mikaylagawarecki mikaylagawarecki Awaiting requested review from mikaylagawarecki mikaylagawarecki is a code owner

Assignees
No one assigned
Labels
open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add explicit typing to nn.Module __init__()
5 participants
@Raman-RH @albanD @Skylion007 @pytorchbot @Raman-Kumar