[DTensor] Assert DTensorSpec has valid placements #158133
Conversation
This helped identify buggy sharding rules during debugging, why not check it in. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158133
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 1 Unrelated FailureAs of commit 7ed15e9 with merge base b4476ca ( NEW FAILURE - The following job has failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This helped identify buggy sharding rules during debugging, why not check it in. cc H-Huang awgu wanchaol fegin fduwjj wz337 d4l3k [ghstack-poisoned]
|
hmm, this looks (?) like a real bug in some dtensor code, better go fix it edit: this was a trivial bug in the unit test itself, fixed |
This helped identify buggy sharding rules during debugging, why not check it in. cc H-Huang awgu wanchaol fegin fduwjj wz337 d4l3k [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -c ghfirst -m "Sorry but this is breaking internally. See D78496151 for details. To validate your fixes internally, you can follow the instructions here: https://fburl.com/fixing-ghfirst-reverts" |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
@wconstab your PR has been successfully reverted. |
This reverts commit 1839e8d. Reverted #158133 on behalf of https://github.com/ZainRizvi due to Sorry but this is breaking internally. See D78496151 for details. To validate your fixes internally, you can follow the instructions here: https://fburl.com/fixing-ghfirst-reverts ([comment](#158133 (comment)))
Summary: This helped identify buggy sharding rules during debugging, why not check it in. Approved by: https://github.com/XilunWu, https://github.com/zpcore ghstack dependencies: #158132 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/1839e8d04b81ee6eda0cff6fbfc218a7a600f6f7 Rollback Plan: Differential Revision: D78929245
Summary: This helped identify buggy sharding rules during debugging, why not check it in. Test Plan: contbuild & OSS CI Rollback Plan: Differential Revision: D78929245
|
Adding |
Stack from ghstack (oldest at bottom):
This helped identify buggy sharding rules during debugging, why not
check it in.
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @d4l3k @pragupta