[BE] Remove __reduce_deploy__ #158291

PaliC · 2025-07-14T22:37:55Z

Stack from ghstack (oldest at bottom):

This PR removes the integration point torch.fx had with torch::deploy (and another minor change).

Note: This PR has some broken mypy errors, but I believe those should have been in the code base beforehand, and should be fixed in a separate PR

cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv @voznesenskym @penguinwu @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela

[ghstack-poisoned]

pytorch-bot · 2025-07-14T22:37:59Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158291

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit e711a50 with merge base d987a6f ():

FLAKY - The following job failed but was likely due to flakiness present on trunk:

trunk / linux-jammy-rocm-py3.10 / test (distributed, 1, 1, linux.rocm.gpu.4) (gh) (similar failure)
distributed/test_c10d_nccl.py::DistributedDataParallelTest::test_grad_layout_1devicemodule_1replicaperprocess

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

pull / linux-jammy-py3_9-clang9-xla / test (xla, 1, 1, lf.linux.12xlarge, unstable) (gh) (#158876)
sccache: error: couldn't connect to server

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]

albanD

SGTM !

albanD · 2025-07-15T15:09:54Z

Skipping bc test as we do want to break these! :D

[ghstack-poisoned]

This PR removes the integration point torch.fx had with torch::deploy (and another minor change). [TODO] There is an expect test I have to rerun before merging this PR cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]

PaliC · 2025-07-15T21:49:53Z

@pytorchbot merge -i

pytorchmergebot · 2025-07-15T21:51:49Z

Merge started

Your change will be merged while ignoring the following 2 checks: Lint / lintrunner-noclang / linux-job, trunk / cuda12.8-py3.10-gcc9-sm80 / build

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-07-16T02:46:50Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Lint / lintrunner-noclang / linux-job

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

…se (#158407) This PR makes some less risky changes to PyObjectSlot as there is a lot of stuff we do not need since there is only one interpreter. Specifically `check_interpreter` and `has_pyobj_nonhermetic` are removed Pull Request resolved: #158407 Approved by: https://github.com/albanD ghstack dependencies: #158288, #158290, #158291

This reverts commit 0b9fb91. Reverted #158291 on behalf of https://github.com/ZainRizvi due to Sorry but this is breaking internally, see D78496147 for details. To validate your fixes internally, you can follow the instructions here: https://fburl.com/fixing-ghfirst-reverts ([comment](#158288 (comment)))

pytorchmergebot · 2025-07-21T23:17:46Z

@PaliC your PR has been reverted as part of the stack under #158288.

This reverts commit 0b9fb91. Reverted pytorch#158291 on behalf of https://github.com/ZainRizvi due to Sorry but this is breaking internally, see D78496147 for details. To validate your fixes internally, you can follow the instructions here: https://fburl.com/fixing-ghfirst-reverts ([comment](pytorch#158288 (comment)))

[ghstack-poisoned]

pytorchmergebot · 2025-07-23T14:37:55Z

Starting merge as part of PR stack under #158407

pytorchmergebot · 2025-07-23T17:53:25Z

Starting merge as part of PR stack under #158407

…se (#158407) This PR makes some less risky changes to PyObjectSlot as there is a lot of stuff we do not need since there is only one interpreter. Specifically `check_interpreter` and `has_pyobj_nonhermetic` are removed Pull Request resolved: #158407 Approved by: https://github.com/albanD ghstack dependencies: #158288, #158290, #158291

@PaliC

This reverts commit 9c68c4d. Reverted #158291 on behalf of https://github.com/ZainRizvi due to Reverting as per offline discussion to fix internal breaks. @PaliC will reland this as a codev diff. Instructions here: https://fburl.com/fixing-ghfirst-reverts ([comment](#158288 (comment)))

pytorchmergebot · 2025-07-25T16:09:46Z

@PaliC your PR has been reverted as part of the stack under #158288.

This PR removes the integration point torch.fx had with torch::deploy (and another minor change). Note: This PR has some broken mypy errors, but I believe those should have been in the code base beforehand, and should be fixed in a separate PR cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]

[ghstack-poisoned]

pytorchmergebot · 2025-07-29T20:00:32Z

Starting merge as part of PR stack under #158407

…se (#158407) This PR makes some less risky changes to PyObjectSlot as there is a lot of stuff we do not need since there is only one interpreter. Specifically `check_interpreter` and `has_pyobj_nonhermetic` are removed Pull Request resolved: #158407 Approved by: https://github.com/albanD ghstack dependencies: #158290, #158291

@PaliC

This reverts commit 9c68c4d. Reverted #158291 on behalf of https://github.com/ZainRizvi due to Reverting as per offline discussion to fix internal breaks. @PaliC will reland this as a codev diff. Instructions here: https://fburl.com/fixing-ghfirst-reverts ([comment](#158288 (comment)))

This PR removes the integration point torch.fx had with torch::deploy (and another minor change). Note: This PR has some broken mypy errors, but I believe those should have been in the code base beforehand, and should be fixed in a separate PR Pull Request resolved: #158291 Approved by: https://github.com/albanD ghstack dependencies: #158290

…se (#158407) This PR makes some less risky changes to PyObjectSlot as there is a lot of stuff we do not need since there is only one interpreter. Specifically `check_interpreter` and `has_pyobj_nonhermetic` are removed Pull Request resolved: #158407 Approved by: https://github.com/albanD ghstack dependencies: #158290, #158291

yangw-dev · 2025-08-01T17:09:18Z

@pytorchbot revert -m "user modified the diff internally after github pr is merged, break the diff train ,please reland this with codev internally" -c ghfirst

pytorchmergebot · 2025-08-01T17:11:01Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot · 2025-08-01T17:11:18Z

Reverting PR 158291 failed

Reason: Command git -C /home/runner/work/pytorch/pytorch revert --no-edit a753a72b144633d1dc556a29e2373886cf73348c returned non-zero exit code 1

Auto-merging c10/core/impl/PyObjectSlot.cpp
Auto-merging c10/core/impl/PyObjectSlot.h
CONFLICT (content): Merge conflict in c10/core/impl/PyObjectSlot.h
Auto-merging torch/csrc/Storage.cpp
error: could not revert a753a72b144... [BE] Modify PyObjectSlot the assume only a single interpreter is in use (#158407)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git revert --continue".
hint: You can instead skip this commit with "git revert --skip".
hint: To abort and get back to the state before "git revert",
hint: run "git revert --abort".
hint: Disable this message with "git config set advice.mergeConflict false"

Details for Dev Infra team

Raised by workflow job

Update

5cb139d

[ghstack-poisoned]

pytorch-bot bot added the release notes: fx release notes category label Jul 14, 2025

This was referenced Jul 14, 2025

[BE] remove torch deploy - conditionals #158288

Closed

[BE] Remove torch deploy | remove torch deploy specific files #158290

Closed

facebook-github-bot added the fx label Jul 14, 2025

Update

bff4c6f

[ghstack-poisoned]

PaliC requested a review from albanD as a code owner July 15, 2025 01:59

pytorch-bot bot added ciflow/inductor module: dynamo labels Jul 15, 2025

PaliC requested a review from malfet July 15, 2025 02:02

Update

bf7c100

[ghstack-poisoned]

albanD approved these changes Jul 15, 2025

View reviewed changes

albanD added the suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) label Jul 15, 2025

Update

158f01e

[ghstack-poisoned]

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 15, 2025

pytorchmergebot added the merging label Jul 15, 2025

This was referenced Jul 15, 2025

[BE][EZ] Remove has_pyobj_nonhermetic from PyObjectSlot #158387

Closed

[BE] Modify PyObjectSlot the assume only a single interpreter is in use #158407

Closed

pytorchmergebot removed the merging label Jul 16, 2025

pytorchmergebot closed this in 0b9fb91 Jul 17, 2025

pytorchmergebot added the Merged label Jul 17, 2025

pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Jul 21, 2025

pytorchmergebot reopened this Jul 21, 2025

Update

8959336

[ghstack-poisoned]

pytorchmergebot closed this in 9c68c4d Jul 23, 2025

pytorchmergebot reopened this Jul 25, 2025

PaliC and others added 2 commits July 25, 2025 17:46

Update

e711a50

[ghstack-poisoned]

pytorchmergebot closed this in b57d1ef Jul 30, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[BE] Remove __reduce_deploy__ #158291

[BE] Remove __reduce_deploy__ #158291

Uh oh!

PaliC commented Jul 14, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented Jul 14, 2025 •

edited

Loading

Uh oh!

albanD left a comment

Uh oh!

albanD commented Jul 15, 2025

Uh oh!

PaliC commented Jul 15, 2025

Uh oh!

pytorchmergebot commented Jul 15, 2025

Uh oh!

pytorchmergebot commented Jul 16, 2025

Uh oh!

pytorchmergebot commented Jul 21, 2025

Uh oh!

pytorchmergebot commented Jul 23, 2025

Uh oh!

pytorchmergebot commented Jul 23, 2025

Uh oh!

pytorchmergebot commented Jul 25, 2025

Uh oh!

pytorchmergebot commented Jul 29, 2025

Uh oh!

yangw-dev commented Aug 1, 2025

Uh oh!

pytorchmergebot commented Aug 1, 2025

Uh oh!

pytorchmergebot commented Aug 1, 2025

Uh oh!

Uh oh!

[BE] Remove __reduce_deploy__ #158291

[BE] Remove __reduce_deploy__ #158291

Uh oh!

Conversation

PaliC commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158291

✅ You can merge normally! (2 Unrelated Failures)

Uh oh!

albanD left a comment

Choose a reason for hiding this comment

Uh oh!

albanD commented Jul 15, 2025

Uh oh!

PaliC commented Jul 15, 2025

Uh oh!

pytorchmergebot commented Jul 15, 2025

Merge started

Uh oh!

pytorchmergebot commented Jul 16, 2025

Merge failed

Uh oh!

pytorchmergebot commented Jul 21, 2025

Uh oh!

pytorchmergebot commented Jul 23, 2025

Uh oh!

pytorchmergebot commented Jul 23, 2025

Uh oh!

pytorchmergebot commented Jul 25, 2025

Uh oh!

pytorchmergebot commented Jul 29, 2025

Uh oh!

yangw-dev commented Aug 1, 2025

Uh oh!

pytorchmergebot commented Aug 1, 2025

Uh oh!

pytorchmergebot commented Aug 1, 2025

Reverting PR 158291 failed

Uh oh!

Uh oh!

PaliC commented Jul 14, 2025 •

edited

Loading

pytorch-bot bot commented Jul 14, 2025 •

edited

Loading