Filter out local timer tests which are unimplemented in Python on AArch64 #158342
+14
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158342
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 38a0d1b with merge base f3913ea ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "module: arm" |
766c517 to
6739075
Compare
H-Huang
reviewed
Jul 17, 2025
| @@ -1551,6 +1551,7 @@ test_linux_aarch64() { | |||
| python test/run_test.py --include test_modules test_mkldnn test_mkldnn_fusion test_openmp test_torch test_dynamic_shapes \ | |||
| test_transformers test_multiprocessing test_numpy_interop test_autograd test_binary_ufuncs test_complex test_spectral_ops \ | |||
| test_foreach test_reductions test_unary_ufuncs test_tensor_creation_ops test_ops test_cpp_extensions_open_device_registration \ | |||
| distributed/elastic/timer/api_test distributed/elastic/timer/local_timer_example distributed/elastic/timer/local_timer_test \ | |||
There was a problem hiding this comment.
how come the tests being added if they are going to be filtered out anyways?
There was a problem hiding this comment.
We want to enable the full test suite eventually, so we want to ensure they're all being skipped, xfailed or passing properly in CI ahead of that.
At some point it would be good to revisit this once we use a non-conda Python to try.
malfet
approved these changes
Jul 24, 2025
…ch64 This stems from using a conda build of Python which incorrectly detects this as unimplemented: conda-forge/python-feedstock#804
6739075 to
38a0d1b
Compare
|
@pytorchbot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stems from using a conda build of Python, which incorrectly detects this as unimplemented:
conda-forge/python-feedstock#804
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta @malfet @snadampal @milpuz01 @aditew01 @nikhil-arm @fadara01 @dzhulgakov