Skip to content

[OpenReg] move fallback tests into test_openreg.py #158441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

[OpenReg] move fallback tests into test_openreg.py #158441

wants to merge 7 commits into from

Conversation

FFFrog
Copy link
Collaborator

@FFFrog FFFrog commented Jul 16, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

  • move fallback tests into test_operneg
  • remove the test_cpp_extensions_open_device_registration.py

@FFFrog
Update
40ad6cf 
[ghstack-poisoned]
@FFFrog FFFrog requested a review from a team as a code owner July 16, 2025 12:40
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 16, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158441

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit c86ecb1 with merge base 1d302ea (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

FFFrog added a commit that referenced this pull request Jul 16, 2025
@FFFrog
[OpenReg] move fallback tests into test_openreg.py
36039ee 
- move fallback tests into test_operneg
- remove the test_cpp_extensions_open_device_registration.py


ghstack-source-id: 7382d5e
Pull-Request-resolved: #158441
This was referenced Jul 16, 2025
Closed
Closed
@FFFrog
Update
25bd916 
[ghstack-poisoned]
FFFrog added a commit that referenced this pull request Jul 16, 2025
@FFFrog
[OpenReg] move fallback tests into test_openreg.py
0bd9e59 
- move fallback tests into test_operneg
- remove the test_cpp_extensions_open_device_registration.py


ghstack-source-id: 0d23c9d
Pull-Request-resolved: #158441
@FFFrog FFFrog mentioned this pull request Jul 16, 2025
Closed
@FFFrog FFFrog added the topic: not user facing topic category label Jul 16, 2025
@FFFrog FFFrog requested review from albanD and desertfire July 17, 2025 01:28
albanD
albanD approved these changes Jul 17, 2025
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@FFFrog
Update
80b57e6 
[ghstack-poisoned]
@FFFrog FFFrog mentioned this pull request Jul 18, 2025
Open
@FFFrog
Update
0649b57 
[ghstack-poisoned]
@FFFrog
Copy link
Collaborator Author

FFFrog commented Jul 21, 2025

@pytorchbot merge -i

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 21, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 4 checks: pull / linux-jammy-py3.13-clang12 / test (dynamo_wrapped, 1, 3, linux.2xlarge), pull / cuda12.8-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu, unstable), Lint / lintrunner-clang / linux-job, Lint / lintrunner-noclang / linux-job

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@FFFrog
Update
ae4983e 
[ghstack-poisoned]
@FFFrog
Copy link
Collaborator Author

FFFrog commented Jul 23, 2025

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 2 checks: Lint / lintrunner-noclang / linux-job, Lint / lintrunner-clang / linux-job

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@FFFrog
Update
1de5a49 
[ghstack-poisoned]
@FFFrog
Update
c86ecb1 
[ghstack-poisoned]
FFFrog added a commit that referenced this pull request Jul 24, 2025
@FFFrog
[OpenReg] move fallback tests into test_openreg.py
6a3bc42 
- move fallback tests into test_operneg
- remove the test_cpp_extensions_open_device_registration.py


ghstack-source-id: 5d99ece
Pull-Request-resolved: #158441
@FFFrog
Copy link
Collaborator Author

FFFrog commented Jul 25, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

yangw-dev pushed a commit that referenced this pull request Aug 1, 2025
@FFFrog @yangw-dev
[OpenReg] move fallback tests into test_openreg.py (#158441)
ef2ba7b 
----

- move fallback tests into test_operneg
- remove the test_cpp_extensions_open_device_registration.py
Pull Request resolved: #158441
Approved by: https://github.com/albanD
ghstack dependencies: #158415, #158440
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD albanD approved these changes

@desertfire desertfire Awaiting requested review from desertfire

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FFFrog @pytorchmergebot @albanD @pytorchbot