unskipped flaky conv2d, rmatmul, and matmul as these now pass #158640
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158640
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 3 Unrelated FailuresAs of commit 3b504bb with merge base 27af877 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "module: arm" |
|
@pytorchbot label "ciflow/linux-aarch64" |
|
@pytorchbot label "module: arm" |
There was a problem hiding this comment.
Thanks for your PR!
Shouldn't we enable test/functorch/test_aotdispatch.py in https://github.com/pytorch/pytorch/blob/main/.ci/pytorch/test.sh#L1557 to exercise them in precommit?
|
@pytorchbot label "ciflow/linux-aarch64" |
|
Yes that would be good, I'll add it in.
…________________________________
From: Fadi Arafeh ***@***.***>
Sent: 21 July 2025 13:52
To: pytorch/pytorch ***@***.***>
Cc: Christina Burge ***@***.***>; Author ***@***.***>
Subject: Re: [pytorch/pytorch] unskipped flaky conv2d, rmatmul, and matmul as these now pass (PR #158640)
@fadara01 commented on this pull request.
Thanks for your PR!
Shouldn't we enable test/functorch/test_aotdispatch.py in https://github.com/pytorch/pytorch/blob/main/.ci/pytorch/test.sh#L1557 to exercise them in precommit?
—
Reply to this email directly, view it on GitHub<#158640 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJ6CBGMJ343PMCJTBSALPYD3JTO7JAVCNFSM6AAAAACB2MY5UKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTAMZXHE3TCOBUGE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
|
|
@zou3519 I'm confused, I thought we are already running these test |
| @@ -1559,6 +1559,10 @@ test_linux_aarch64() { | |||
| test_foreach test_reductions test_unary_ufuncs test_tensor_creation_ops test_ops test_cpp_extensions_open_device_registration \ | |||
| --shard "$SHARD_NUMBER" "$NUM_TEST_SHARDS" --verbose | |||
|
|
|||
| #functorch tests | |||
| python test/run_test.py --include functorch/test_aotdispatch.py \ | |||
| --shard "$SHARD_NUMBER" "$NUM_TEST_SHARDS" --verbose | |||
There was a problem hiding this comment.
til arm and aarch64 are the same thing
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / test (default, 2, 3, macos-m1-stable) Details for Dev Infra teamRaised by workflow job |
|
@christinaburge you need to CLA your other email |
983da4a to
3b504bb
Compare
These tests were flaky, they now pass on aarch64 after 100 runs. Logs are attached.
aotdispatch_test_detailed_flakyonly.log
aotdispatch_test_detailed_flakyonly2.log
aotdispatch_test_summary_flakyonly.log
aotdispatch_test_summary_flakyonly2.log
cc @malfet @snadampal @milpuz01 @aditew01 @nikhil-arm @fadara01