[DTensor] Assert DTensorSpec has valid placements (#158133) #159091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This helped identify buggy sharding rules during debugging, why not check it in. Test Plan: contbuild & OSS CI Rollback Plan: Differential Revision: D78929245
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159091
Note: Links to docs will display an error until the docs builds have been completed. ❌ 6 New Failures, 4 Unrelated FailuresAs of commit fba29ce with merge base efc810c ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D78929245 |
XilunWu
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This helped identify buggy sharding rules during debugging, why not
check it in.
Re-land of #158133, i botched the process of rebasing the internal diff and re-linking it to the original PR so I need a new stamp. The difference this time is I have already landed some internal diffs to fix broken cases and will land from fbcode after verifying those tests pass.
Differential Revision: D78929245
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @d4l3k @pragupta