Remove usage of fsspec in HF consolidation script #159392
Closed
+34
−106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving towards just supporting local storage to take advantage of HF apis such as safe_open. This PR removes fsspec usages and relies on local storage only Differential Revision: [D78997975](https://our.internmc.facebook.com/intern/diff/D78997975/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159392
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d3f0cda with merge base eed9dbf ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jul 29, 2025
|
This pull request was exported from Phabricator. Differential Revision: D78997975 |
Skylion007
reviewed
Jul 30, 2025
| return f.read(end_offset - start_offset) | ||
| # Use mmap for efficient access | ||
| with open(file_path, "rb") as f: | ||
| with mmap.mmap(f.fileno(), 0, access=mmap.ACCESS_READ) as mm: |
There was a problem hiding this comment.
Put both context managers on the same with statement to reduce unnecessary indent
There was a problem hiding this comment.
this doesn't work because the mmap call needs to be nested in the open
| output_files_data[output_path] = _OutputFileData() | ||
|
|
||
| # Find all safetensors files in the input directory | ||
| safetensors_files = [] | ||
| for file in input_fs.ls(input_dir, detail=False): | ||
| for file in os.listdir(input_dir): |
There was a problem hiding this comment.
Since this is now local, why not just glob or iglob with the suffix? Would remove the need for os.path joins below? Also would turn it into one line glob.glob(os.path.join(input_dir,f"*{SUFFIX}"))
Moving towards just supporting local storage to take advantage of HF apis such as safe_open. This PR removes fsspec usages and relies on local storage only Differential Revision: [D78997975](https://our.internmc.facebook.com/intern/diff/D78997975/) cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta [ghstack-poisoned]
ankitageorge
added a commit
that referenced
this pull request
Aug 1, 2025
Pull Request resolved: #159392 Moving towards just supporting local storage to take advantage of HF apis such as safe_open. This PR removes fsspec usages and relies on local storage only ghstack-source-id: 300119133 @exported-using-ghexport Differential Revision: [D78997975](https://our.internmc.facebook.com/intern/diff/D78997975/)
|
This pull request was exported from Phabricator. Differential Revision: D78997975 |
Moving towards just supporting local storage to take advantage of HF apis such as safe_open. This PR removes fsspec usages and relies on local storage only Differential Revision: [D78997975](https://our.internmc.facebook.com/intern/diff/D78997975/) cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D78997975 |
sibuachu
approved these changes
Aug 12, 2025
sibuachu
approved these changes
Aug 12, 2025
sibuachu
approved these changes
Aug 12, 2025
Moving towards just supporting local storage to take advantage of HF apis such as safe_open. This was already done in Storage component in #159405. This PR removes fsspec usages in consolidation script and relies on local storage only Differential Revision: [D78997975](https://our.internmc.facebook.com/intern/diff/D78997975/) cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta [ghstack-poisoned]
ankitageorge
added a commit
that referenced
this pull request
Aug 12, 2025
Pull Request resolved: #159392 Moving towards just supporting local storage to take advantage of HF apis such as safe_open. This PR removes fsspec usages and relies on local storage only ghstack-source-id: 302105247 @exported-using-ghexport Differential Revision: [D78997975](https://our.internmc.facebook.com/intern/diff/D78997975/)
|
This pull request was exported from Phabricator. Differential Revision: D78997975 |
Moving towards just supporting local storage to take advantage of HF apis such as safe_open. This was already done in Storage component in #159405. This PR removes fsspec usages in consolidation script and relies on local storage only Differential Revision: [D78997975](https://our.internmc.facebook.com/intern/diff/D78997975/) cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta [ghstack-poisoned]
ankitageorge
added a commit
that referenced
this pull request
Aug 12, 2025
Pull Request resolved: #159392 Moving towards just supporting local storage to take advantage of HF apis such as safe_open. This PR removes fsspec usages and relies on local storage only ghstack-source-id: 302468409 @exported-using-ghexport Differential Revision: [D78997975](https://our.internmc.facebook.com/intern/diff/D78997975/)
|
This pull request was exported from Phabricator. Differential Revision: D78997975 |
|
@pytorchmergebot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Moving towards just supporting local storage to take advantage of HF apis such as safe_open. This was already done in Storage component in #159405. This PR removes fsspec usages in consolidation script and relies on local storage only
Differential Revision: D78997975
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta