Use safe_open in HF consolidation #159395
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use safe_open to read tensors for HF consolidation instead of reading the bytes with f.read() which is having worse performance. Differential Revision: [D79105491](https://our.internmc.facebook.com/intern/diff/D79105491/) [ghstack-poisoned]
This was referenced Jul 29, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159395
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 1c4ecd5 with merge base f89c28c ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jul 29, 2025
ankitageorge
added a commit
that referenced
this pull request
Jul 29, 2025
Use safe_open to read tensors for HF consolidation instead of reading the bytes with f.read() which is having worse performance. Differential Revision: [D79105491](https://our.internmc.facebook.com/intern/diff/D79105491/) ghstack-source-id: 299325606 Pull Request resolved: #159395
|
This pull request was exported from Phabricator. Differential Revision: D79105491 |
Use safe_open to read tensors for HF consolidation instead of reading the bytes with f.read() which is having worse performance. Differential Revision: [D79105491](https://our.internmc.facebook.com/intern/diff/D79105491/) cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta [ghstack-poisoned]
ankitageorge
added a commit
that referenced
this pull request
Aug 1, 2025
Pull Request resolved: #159395 Use safe_open to read tensors for HF consolidation instead of reading the bytes with f.read() which is having worse performance. ghstack-source-id: 300123326 @exported-using-ghexport Differential Revision: [D79105491](https://our.internmc.facebook.com/intern/diff/D79105491/)
|
This pull request was exported from Phabricator. Differential Revision: D79105491 |
Use safe_open to read tensors for HF consolidation instead of reading the bytes with f.read() which is having worse performance. Differential Revision: [D79105491](https://our.internmc.facebook.com/intern/diff/D79105491/) cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta [ghstack-poisoned]
ankitageorge
added a commit
that referenced
this pull request
Aug 1, 2025
Pull Request resolved: #159395 Use safe_open to read tensors for HF consolidation instead of reading the bytes with f.read() which is having worse performance. ghstack-source-id: 300135655 @exported-using-ghexport Differential Revision: [D79105491](https://our.internmc.facebook.com/intern/diff/D79105491/)
|
This pull request was exported from Phabricator. Differential Revision: D79105491 |
Use safe_open to read tensors for HF consolidation instead of reading the bytes with f.read() which is having worse performance. Differential Revision: [D79105491](https://our.internmc.facebook.com/intern/diff/D79105491/) cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta [ghstack-poisoned]
ankitageorge
added a commit
that referenced
this pull request
Aug 1, 2025
Pull Request resolved: #159395 Use safe_open to read tensors for HF consolidation instead of reading the bytes with f.read() which is having worse performance. ghstack-source-id: 300147538 @exported-using-ghexport Differential Revision: [D79105491](https://our.internmc.facebook.com/intern/diff/D79105491/)
|
This pull request was exported from Phabricator. Differential Revision: D79105491 |
Use safe_open to read tensors for HF consolidation instead of reading the bytes with f.read() which is having worse performance. Differential Revision: [D79105491](https://our.internmc.facebook.com/intern/diff/D79105491/) cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta [ghstack-poisoned]
ankitageorge
added a commit
that referenced
this pull request
Aug 1, 2025
Pull Request resolved: #159395 Use safe_open to read tensors for HF consolidation instead of reading the bytes with f.read() which is having worse performance. ghstack-source-id: 300161454 @exported-using-ghexport Differential Revision: [D79105491](https://our.internmc.facebook.com/intern/diff/D79105491/)
|
This pull request was exported from Phabricator. Differential Revision: D79105491 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Use safe_open to read tensors for HF consolidation instead of reading the bytes with f.read() which is having worse performance.
Differential Revision: D79105491
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta