Skip to content

grid_sampler_3d for MPS #159421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

grid_sampler_3d for MPS #159421

wants to merge 8 commits into from

Conversation

mlaves
Copy link

@mlaves mlaves commented Jul 29, 2025 •
edited
Loading

Metal implementation of grid_sampler_3d, including backward pass.

Runtime benchmarks vs. CPU (M2 Max)

Batch size:  1, CPU time: 7.164317 ms, MPS time: 0.817350 ms, speedup: 8.77x
Batch size:  2, CPU time: 14.793888 ms, MPS time: 1.111496 ms, speedup: 13.31x
Batch size:  4, CPU time: 30.779025 ms, MPS time: 1.712583 ms, speedup: 17.97x
Batch size:  8, CPU time: 68.820854 ms, MPS time: 3.391506 ms, speedup: 20.29x
Batch size: 16, CPU time: 142.618127 ms, MPS time: 5.831585 ms, speedup: 24.46x

Output accuracy test vs. CPU

Click to expand 
Grid Sampler 3D Output Accuracy Test (MPS vs CPU)
input_shape           grid_shape         interp   padding   align_corners   max_diff      mean_diff     sum_diff
------------------------------------------------------------------------------------------------------------------------
(1, 3, 128, 128, 128) (1, 64, 64, 64, 3)   0        0         0   0.00000000   0.00000000   0.00000000
(1, 3, 128, 128, 128) (1, 64, 64, 64, 3)   0        0         1   0.00000000   0.00000000   0.00000000
(1, 3, 128, 128, 128) (1, 64, 64, 64, 3)   0        1         0   0.00000000   0.00000000   0.00000000
(1, 3, 128, 128, 128) (1, 64, 64, 64, 3)   0        1         1   0.00000000   0.00000000   0.00000000
(1, 3, 128, 128, 128) (1, 64, 64, 64, 3)   0        2         0   0.00000000   0.00000000   0.00000000
(1, 3, 128, 128, 128) (1, 64, 64, 64, 3)   0        2         1   0.00000000   0.00000000   0.00000000
(1, 3, 128, 128, 128) (1, 64, 64, 64, 3)   1        0         0   0.00000000   0.00000000   0.00000000
(1, 3, 128, 128, 128) (1, 64, 64, 64, 3)   1        0         1   0.00000000   0.00000000   0.00000000
(1, 3, 128, 128, 128) (1, 64, 64, 64, 3)   1        1         0   0.00000000   0.00000000   0.00000000
(1, 3, 128, 128, 128) (1, 64, 64, 64, 3)   1        1         1   0.00000000   0.00000000   0.00000000
(1, 3, 128, 128, 128) (1, 64, 64, 64, 3)   1        2         0   0.00000000   0.00000000   0.00000000
(1, 3, 128, 128, 128) (1, 64, 64, 64, 3)   1        2         1   0.00000000   0.00000000   0.00000000
(1, 3, 128, 128, 128) (1, 1, 1, 1, 3)      0        0         0   0.00000000   0.00000000   0.00000000
(1, 3, 128, 128, 128) (1, 1, 1, 1, 3)      0        0         1   0.00000000   0.00000000   0.00000000
(1, 3, 128, 128, 128) (1, 1, 1, 1, 3)      0        1         0   0.00000000   0.00000000   0.00000000
(1, 3, 128, 128, 128) (1, 1, 1, 1, 3)      0        1         1   0.00000000   0.00000000   0.00000000
(1, 3, 128, 128, 128) (1, 1, 1, 1, 3)      0        2         0   0.00000000   0.00000000   0.00000000
(1, 3, 128, 128, 128) (1, 1, 1, 1, 3)      0        2         1   0.00000000   0.00000000   0.00000000
(1, 3, 128, 128, 128) (1, 1, 1, 1, 3)      1        0         0   0.00000000   0.00000000   0.00000000
(1, 3, 128, 128, 128) (1, 1, 1, 1, 3)      1        0         1   0.00000000   0.00000000   0.00000000
(1, 3, 128, 128, 128) (1, 1, 1, 1, 3)      1        1         0   0.00000000   0.00000000   0.00000000
(1, 3, 128, 128, 128) (1, 1, 1, 1, 3)      1        1         1   0.00000000   0.00000000   0.00000000
(1, 3, 128, 128, 128) (1, 1, 1, 1, 3)      1        2         0   0.00000000   0.00000000   0.00000000
(1, 3, 128, 128, 128) (1, 1, 1, 1, 3)      1        2         1   0.00000000   0.00000000   0.00000000
(1, 3, 128, 128, 128) (1, 8, 8, 8, 3)      0        0         0   0.00000000   0.00000000   0.00000000
(1, 3, 128, 128, 128) (1, 8, 8, 8, 3)      0        0         1   0.00000000   0.00000000   0.00000000
(1, 3, 128, 128, 128) (1, 8, 8, 8, 3)      0        1         0   0.00000000   0.00000000   0.00000000
(1, 3, 128, 128, 128) (1, 8, 8, 8, 3)      0        1         1   0.00000000   0.00000000   0.00000000
(1, 3, 128, 128, 128) (1, 8, 8, 8, 3)      0        2         0   0.00000000   0.00000000   0.00000000
(1, 3, 128, 128, 128) (1, 8, 8, 8, 3)      0        2         1   0.00000000   0.00000000   0.00000000
(1, 3, 128, 128, 128) (1, 8, 8, 8, 3)      1        0         0   0.00000000   0.00000000   0.00000000
(1, 3, 128, 128, 128) (1, 8, 8, 8, 3)      1        0         1   0.00000000   0.00000000   0.00000000
(1, 3, 128, 128, 128) (1, 8, 8, 8, 3)      1        1         0   0.00000000   0.00000000   0.00000000
(1, 3, 128, 128, 128) (1, 8, 8, 8, 3)      1        1         1   0.00000000   0.00000000   0.00000000
(1, 3, 128, 128, 128) (1, 8, 8, 8, 3)      1        2         0   0.00000000   0.00000000   0.00000000
(1, 3, 128, 128, 128) (1, 8, 8, 8, 3)      1        2         1   0.00000000   0.00000000   0.00000000
(2, 1, 32, 32, 32)    (2, 16, 16, 16, 3)   0        0         0   0.00000000   0.00000000   0.00000000
(2, 1, 32, 32, 32)    (2, 16, 16, 16, 3)   0        0         1   0.00000000   0.00000000   0.00000000
(2, 1, 32, 32, 32)    (2, 16, 16, 16, 3)   0        1         0   0.00000000   0.00000000   0.00000000
(2, 1, 32, 32, 32)    (2, 16, 16, 16, 3)   0        1         1   0.00000000   0.00000000   0.00000000
(2, 1, 32, 32, 32)    (2, 16, 16, 16, 3)   0        2         0   0.00000000   0.00000000   0.00000000
(2, 1, 32, 32, 32)    (2, 16, 16, 16, 3)   0        2         1   0.00000000   0.00000000   0.00000000
(2, 1, 32, 32, 32)    (2, 16, 16, 16, 3)   1        0         0   0.00000000   0.00000000   0.00000000
(2, 1, 32, 32, 32)    (2, 16, 16, 16, 3)   1        0         1   0.00000000   0.00000000   0.00000000
(2, 1, 32, 32, 32)    (2, 16, 16, 16, 3)   1        1         0   0.00000000   0.00000000   0.00000000
(2, 1, 32, 32, 32)    (2, 16, 16, 16, 3)   1        1         1   0.00000000   0.00000000   0.00000000
(2, 1, 32, 32, 32)    (2, 16, 16, 16, 3)   1        2         0   0.00000000   0.00000000   0.00000000
(2, 1, 32, 32, 32)    (2, 16, 16, 16, 3)   1        2         1   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 64, 64, 64, 3)   0        0         0   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 64, 64, 64, 3)   0        0         1   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 64, 64, 64, 3)   0        1         0   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 64, 64, 64, 3)   0        1         1   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 64, 64, 64, 3)   0        2         0   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 64, 64, 64, 3)   0        2         1   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 64, 64, 64, 3)   1        0         0   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 64, 64, 64, 3)   1        0         1   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 64, 64, 64, 3)   1        1         0   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 64, 64, 64, 3)   1        1         1   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 64, 64, 64, 3)   1        2         0   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 64, 64, 64, 3)   1        2         1   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 1, 1, 1, 3)      0        0         0   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 1, 1, 1, 3)      0        0         1   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 1, 1, 1, 3)      0        1         0   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 1, 1, 1, 3)      0        1         1   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 1, 1, 1, 3)      0        2         0   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 1, 1, 1, 3)      0        2         1   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 1, 1, 1, 3)      1        0         0   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 1, 1, 1, 3)      1        0         1   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 1, 1, 1, 3)      1        1         0   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 1, 1, 1, 3)      1        1         1   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 1, 1, 1, 3)      1        2         0   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 1, 1, 1, 3)      1        2         1   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 8, 8, 8, 3)      0        0         0   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 8, 8, 8, 3)      0        0         1   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 8, 8, 8, 3)      0        1         0   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 8, 8, 8, 3)      0        1         1   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 8, 8, 8, 3)      0        2         0   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 8, 8, 8, 3)      0        2         1   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 8, 8, 8, 3)      1        0         0   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 8, 8, 8, 3)      1        0         1   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 8, 8, 8, 3)      1        1         0   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 8, 8, 8, 3)      1        1         1   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 8, 8, 8, 3)      1        2         0   0.00000000   0.00000000   0.00000000
(1, 1, 1, 1, 1)       (1, 8, 8, 8, 3)      1        2         1   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 64, 64, 64, 3)   0        0         0   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 64, 64, 64, 3)   0        0         1   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 64, 64, 64, 3)   0        1         0   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 64, 64, 64, 3)   0        1         1   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 64, 64, 64, 3)   0        2         0   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 64, 64, 64, 3)   0        2         1   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 64, 64, 64, 3)   1        0         0   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 64, 64, 64, 3)   1        0         1   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 64, 64, 64, 3)   1        1         0   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 64, 64, 64, 3)   1        1         1   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 64, 64, 64, 3)   1        2         0   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 64, 64, 64, 3)   1        2         1   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 1, 1, 1, 3)      0        0         0   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 1, 1, 1, 3)      0        0         1   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 1, 1, 1, 3)      0        1         0   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 1, 1, 1, 3)      0        1         1   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 1, 1, 1, 3)      0        2         0   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 1, 1, 1, 3)      0        2         1   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 1, 1, 1, 3)      1        0         0   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 1, 1, 1, 3)      1        0         1   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 1, 1, 1, 3)      1        1         0   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 1, 1, 1, 3)      1        1         1   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 1, 1, 1, 3)      1        2         0   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 1, 1, 1, 3)      1        2         1   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 8, 8, 8, 3)      0        0         0   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 8, 8, 8, 3)      0        0         1   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 8, 8, 8, 3)      0        1         0   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 8, 8, 8, 3)      0        1         1   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 8, 8, 8, 3)      0        2         0   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 8, 8, 8, 3)      0        2         1   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 8, 8, 8, 3)      1        0         0   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 8, 8, 8, 3)      1        0         1   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 8, 8, 8, 3)      1        1         0   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 8, 8, 8, 3)      1        1         1   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 8, 8, 8, 3)      1        2         0   0.00000000   0.00000000   0.00000000
(1, 4, 16, 16, 16)    (1, 8, 8, 8, 3)      1        2         1   0.00000000   0.00000000   0.00000000
------------------------------------------------------------------------------------------------------------------------
Summary:
Total tests: 120
Failed tests: 0
Max difference overall: 0.00000000
Mean difference overall: 0.00000000
Sum difference overall: 0.00000000

Edge Cases Test
input_shape           grid_shape         interp   padding   align_corners   max_diff      mean_diff     sum_diff
------------------------------------------------------------------------------------------------------------------------
(1, 1, 2, 2, 2)       (1, 1, 1, 1, 3)      0        0         0   0.00000000   0.00000000   0.00000000
(1, 1, 2, 2, 2)       (1, 1, 1, 1, 3)      0        0         1   0.00000000   0.00000000   0.00000000
(1, 1, 2, 2, 2)       (1, 1, 1, 1, 3)      0        1         0   0.00000000   0.00000000   0.00000000
(1, 1, 2, 2, 2)       (1, 1, 1, 1, 3)      0        1         1   0.00000000   0.00000000   0.00000000
(1, 1, 2, 2, 2)       (1, 1, 1, 1, 3)      1        0         0   0.00000000   0.00000000   0.00000000
(1, 1, 2, 2, 2)       (1, 1, 1, 1, 3)      1        0         1   0.00000000   0.00000000   0.00000000
(1, 1, 2, 2, 2)       (1, 1, 1, 1, 3)      1        1         0   0.00000000   0.00000000   0.00000000
(1, 1, 2, 2, 2)       (1, 1, 1, 1, 3)      1        1         1   0.00000000   0.00000000   0.00000000
(1, 1, 1, 10, 10)     (1, 1, 5, 5, 3)      0        0         0   0.00000000   0.00000000   0.00000000
(1, 1, 1, 10, 10)     (1, 1, 5, 5, 3)      0        0         1   0.00000000   0.00000000   0.00000000
(1, 1, 1, 10, 10)     (1, 1, 5, 5, 3)      0        1         0   0.00000000   0.00000000   0.00000000
(1, 1, 1, 10, 10)     (1, 1, 5, 5, 3)      0        1         1   0.00000000   0.00000000   0.00000000
(1, 1, 1, 10, 10)     (1, 1, 5, 5, 3)      1        0         0   0.00000000   0.00000000   0.00000000
(1, 1, 1, 10, 10)     (1, 1, 5, 5, 3)      1        0         1   0.00000000   0.00000000   0.00000000
(1, 1, 1, 10, 10)     (1, 1, 5, 5, 3)      1        1         0   0.00000000   0.00000000   0.00000000
(1, 1, 1, 10, 10)     (1, 1, 5, 5, 3)      1        1         1   0.00000000   0.00000000   0.00000000
(1, 16, 8, 8, 8)      (1, 4, 4, 4, 3)      0        0         0   0.00000000   0.00000000   0.00000000
(1, 16, 8, 8, 8)      (1, 4, 4, 4, 3)      0        0         1   0.00000000   0.00000000   0.00000000
(1, 16, 8, 8, 8)      (1, 4, 4, 4, 3)      0        1         0   0.00000000   0.00000000   0.00000000
(1, 16, 8, 8, 8)      (1, 4, 4, 4, 3)      0        1         1   0.00000000   0.00000000   0.00000000
(1, 16, 8, 8, 8)      (1, 4, 4, 4, 3)      1        0         0   0.00000000   0.00000000   0.00000000
(1, 16, 8, 8, 8)      (1, 4, 4, 4, 3)      1        0         1   0.00000000   0.00000000   0.00000000
(1, 16, 8, 8, 8)      (1, 4, 4, 4, 3)      1        1         0   0.00000000   0.00000000   0.00000000
(1, 16, 8, 8, 8)      (1, 4, 4, 4, 3)      1        1         1   0.00000000   0.00000000   0.00000000

All tests passed!

Gradient accuracy test vs. CPU

Click to expand 
grad wrt. input
input_shape           grid_shape         interp   padding   align_corners   diff
(1, 3, 128, 128, 128) (1, 64, 64, 64, 3)   0        0         0    6.324674117763607e-10
(1, 3, 128, 128, 128) (1, 64, 64, 64, 3)   0        0         1    7.693850001544433e-10
(1, 3, 128, 128, 128) (1, 64, 64, 64, 3)   0        1         0    6.303384481043395e-10
(1, 3, 128, 128, 128) (1, 64, 64, 64, 3)   0        1         1    7.976201921167103e-10
(1, 3, 128, 128, 128) (1, 64, 64, 64, 3)   1        0         0                      0.0
(1, 3, 128, 128, 128) (1, 64, 64, 64, 3)   1        0         1                      0.0
(1, 3, 128, 128, 128) (1, 64, 64, 64, 3)   1        1         0                      0.0
(1, 3, 128, 128, 128) (1, 64, 64, 64, 3)   1        1         1                      0.0
(1, 3, 128, 128, 128) (1, 1, 1, 1, 3)      0        0         0                      0.0
(1, 3, 128, 128, 128) (1, 1, 1, 1, 3)      0        0         1                      0.0
(1, 3, 128, 128, 128) (1, 1, 1, 1, 3)      0        1         0                      0.0
(1, 3, 128, 128, 128) (1, 1, 1, 1, 3)      0        1         1                      0.0
(1, 3, 128, 128, 128) (1, 1, 1, 1, 3)      1        0         0                      0.0
(1, 3, 128, 128, 128) (1, 1, 1, 1, 3)      1        0         1                      0.0
(1, 3, 128, 128, 128) (1, 1, 1, 1, 3)      1        1         0                      0.0
(1, 3, 128, 128, 128) (1, 1, 1, 1, 3)      1        1         1                      0.0
(1, 1, 1, 1, 1)       (1, 64, 64, 64, 3)   0        0         0   1.1622905731201172e-06
(1, 1, 1, 1, 1)       (1, 64, 64, 64, 3)   0        0         1                      0.0
(1, 1, 1, 1, 1)       (1, 64, 64, 64, 3)   0        1         0                      0.0
(1, 1, 1, 1, 1)       (1, 64, 64, 64, 3)   0        1         1                      0.0
(1, 1, 1, 1, 1)       (1, 64, 64, 64, 3)   1        0         0                      0.0
(1, 1, 1, 1, 1)       (1, 64, 64, 64, 3)   1        0         1                      0.0
(1, 1, 1, 1, 1)       (1, 64, 64, 64, 3)   1        1         0                      0.0
(1, 1, 1, 1, 1)       (1, 64, 64, 64, 3)   1        1         1                      0.0
(1, 1, 1, 1, 1)       (1, 1, 1, 1, 3)      0        0         0                      0.0
(1, 1, 1, 1, 1)       (1, 1, 1, 1, 3)      0        0         1                      0.0
(1, 1, 1, 1, 1)       (1, 1, 1, 1, 3)      0        1         0                      0.0
(1, 1, 1, 1, 1)       (1, 1, 1, 1, 3)      0        1         1                      0.0
(1, 1, 1, 1, 1)       (1, 1, 1, 1, 3)      1        0         0                      0.0
(1, 1, 1, 1, 1)       (1, 1, 1, 1, 3)      1        0         1                      0.0
(1, 1, 1, 1, 1)       (1, 1, 1, 1, 3)      1        1         0                      0.0
(1, 1, 1, 1, 1)       (1, 1, 1, 1, 3)      1        1         1                      0.0
max diff for input gradients:  1.1622905731201172e-06
grad wrt. grid
input_shape           grid_shape         interp   padding   align_corners   diff
(1, 3, 128, 128, 128) (1, 64, 64, 64, 3)   0        0         0                      0.0
(1, 3, 128, 128, 128) (1, 64, 64, 64, 3)   0        0         1                      0.0
(1, 3, 128, 128, 128) (1, 64, 64, 64, 3)   0        1         0                      0.0
(1, 3, 128, 128, 128) (1, 64, 64, 64, 3)   0        1         1                      0.0
(1, 3, 128, 128, 128) (1, 64, 64, 64, 3)   1        0         0                      0.0
(1, 3, 128, 128, 128) (1, 64, 64, 64, 3)   1        0         1                      0.0
(1, 3, 128, 128, 128) (1, 64, 64, 64, 3)   1        1         0                      0.0
(1, 3, 128, 128, 128) (1, 64, 64, 64, 3)   1        1         1                      0.0
(1, 3, 128, 128, 128) (1, 1, 1, 1, 3)      0        0         0                      0.0
(1, 3, 128, 128, 128) (1, 1, 1, 1, 3)      0        0         1                      0.0
(1, 3, 128, 128, 128) (1, 1, 1, 1, 3)      0        1         0                      0.0
(1, 3, 128, 128, 128) (1, 1, 1, 1, 3)      0        1         1                      0.0
(1, 3, 128, 128, 128) (1, 1, 1, 1, 3)      1        0         0                      0.0
(1, 3, 128, 128, 128) (1, 1, 1, 1, 3)      1        0         1                      0.0
(1, 3, 128, 128, 128) (1, 1, 1, 1, 3)      1        1         0                      0.0
(1, 3, 128, 128, 128) (1, 1, 1, 1, 3)      1        1         1                      0.0
(1, 1, 1, 1, 1)       (1, 64, 64, 64, 3)   0        0         0                      0.0
(1, 1, 1, 1, 1)       (1, 64, 64, 64, 3)   0        0         1                      0.0
(1, 1, 1, 1, 1)       (1, 64, 64, 64, 3)   0        1         0                      0.0
(1, 1, 1, 1, 1)       (1, 64, 64, 64, 3)   0        1         1                      0.0
(1, 1, 1, 1, 1)       (1, 64, 64, 64, 3)   1        0         0                      0.0
(1, 1, 1, 1, 1)       (1, 64, 64, 64, 3)   1        0         1                      0.0
(1, 1, 1, 1, 1)       (1, 64, 64, 64, 3)   1        1         0                      0.0
(1, 1, 1, 1, 1)       (1, 64, 64, 64, 3)   1        1         1                      0.0
(1, 1, 1, 1, 1)       (1, 1, 1, 1, 3)      0        0         0                      0.0
(1, 1, 1, 1, 1)       (1, 1, 1, 1, 3)      0        0         1                      0.0
(1, 1, 1, 1, 1)       (1, 1, 1, 1, 3)      0        1         0                      0.0
(1, 1, 1, 1, 1)       (1, 1, 1, 1, 3)      0        1         1                      0.0
(1, 1, 1, 1, 1)       (1, 1, 1, 1, 3)      1        0         0                      0.0
(1, 1, 1, 1, 1)       (1, 1, 1, 1, 3)      1        0         1                      0.0
(1, 1, 1, 1, 1)       (1, 1, 1, 1, 3)      1        1         0                      0.0
(1, 1, 1, 1, 1)       (1, 1, 1, 1, 3)      1        1         1                      0.0
max diff for grid gradients:  0.0

@mlaves mlaves requested review from kulinseth and malfet as code owners July 29, 2025 21:24
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 29, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159421

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 36d9498 with merge base c665594 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: mps Release notes category label Jul 29, 2025
@github-actions GitHub Actions
Copy link
Contributor

Attention! native_functions.yaml was changed

If you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info.

Caused by:

Skylion007
Skylion007 reviewed Aug 3, 2025
View reviewed changes
Skylion007
Skylion007 reviewed Aug 3, 2025
View reviewed changes
@mlaves mlaves requested a review from Skylion007 August 3, 2025 20:58
Skylion007
Skylion007 approved these changes Aug 5, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulinseth kulinseth kulinseth approved these changes

@Skylion007 Skylion007 Skylion007 approved these changes

@malfet malfet Awaiting requested review from malfet malfet is a code owner

Assignees
No one assigned
Labels
open source release notes: mps Release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mlaves @kulinseth @Skylion007 @pytorchbot