Skip to content

[ci][inductor dashboard] Remove torchao install as its unused #159501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[ci][inductor dashboard] Remove torchao install as its unused #159501

wants to merge 1 commit into from

Conversation

anijain2305
Copy link
Contributor

As Title

@anijain2305 anijain2305 requested a review from a team as a code owner July 30, 2025 18:55
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 30, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159501

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures, 3 Unrelated Failures

As of commit 1c8b706 with merge base debc059 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jul 30, 2025
@anijain2305 anijain2305 added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 30, 2025
@huydhn
Copy link
Contributor

huydhn commented Aug 5, 2025

If this is indeed not need, you will need to remove install_torchao from the test script too, for example https://github.com/pytorch/pytorch/blob/main/.ci/pytorch/test.sh#L1697. The configs in the workflow only tell CI build jobs to build torchao and get the wheel ready before starting the test. When install_torchao is still there in the test script and the wheel is not there, it will still attempt to build torchao as usual.

huydhn
huydhn requested changes Aug 5, 2025
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to clean up install_torchao from the test script too, for example https://github.com/pytorch/pytorch/blob/main/.ci/pytorch/test.sh#L1697.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huydhn huydhn huydhn requested changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anijain2305 @huydhn