Add new_empty (with dtype argument only) to torch::stable #159508

mikaylagawarecki · 2025-07-30T20:47:49Z

Stack from ghstack (oldest at bottom):

…(pending header-onlyness) [ghstack-poisoned]

pytorch-bot · 2025-07-30T20:47:53Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159508

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures

As of commit ae40182 with merge base 556e2a7 ():

NEW FAILURES - The following jobs have failed:

inductor / unit-test / linux-jammy-cpu-py3.9-gcc11-inductor / test (inductor_amx, 1, 2, linux.8xlarge.amx) (gh)
'Test'
inductor / unit-test / linux-jammy-cpu-py3.9-gcc11-inductor / test (inductor_avx2, 1, 2, linux.10xlarge.avx2) (gh)
'Test'
pull / linux-jammy-py3.9-clang12 / test (default, 4, 5, linux.4xlarge) (gh)
'Test'
pull / linux-jammy-py3.9-gcc11 / test (default, 4, 5, linux.2xlarge) (gh)
'Test'

This comment was automatically generated by Dr. CI and updates every 15 minutes.

…(pending header-onlyness) ghstack-source-id: 6cde171 Pull Request resolved: #159508

github-actions · 2025-07-30T20:49:09Z

This PR needs a `release notes:` label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

…le::Tensor (pending header-onlyness)" needs ScalarType.h, which needs to be header-only [ghstack-poisoned]

…(pending header-onlyness) ghstack-source-id: b06a267 Pull Request resolved: #159508

…le::Tensor (pending header-onlyness)" needs ScalarType.h, which needs to be header-only [ghstack-poisoned]

ghstack-source-id: 4c53a24 Pull Request resolved: #159508

mikaylagawarecki · 2025-08-11T21:16:11Z

torchgen/gen_aoti_c_shim.py

+            if not has_function_variant:
+                # Functions with both function and method variants can use the at::{*}_symint version
+                # (e.g., narrow -> at::narrow_symint), BUT
+                # Method-only functions with symint parameters should use at::symint:: namespace
+                # Remove the _symint suffix since at::symint:: namespace uses the base name
+                # (e.g., new_empty -> at::symint::new_empty<c10::SymInt>)
+                base_name = cpp_sig.name()
+                base_name = base_name.removesuffix("_symint")  # Remove "_symint" suffix
+                return f"at::symint::{base_name}<c10::SymInt>"
+


This is the relevant part here

pytorch/torchgen/gen.py

Lines 717 to 739 in 6d91d6d

if Variant.function in f.variants:

result += f"""

// aten::{f.func}

inline {sig.decl()} {{

return at::_ops::{f.func.name.unambiguous_name()}::call({exprs_str});

}}"""

# The template function can be used from template situations

# where you want to switch between the symint or not version

# depending on a template argument

#

# NB: we ALWAYS generate this even for methods. But we put it in

# this header so it can take advantage of per-op headers

if has_symint:

result += f"""

namespace symint {{

template <typename T, typename = std::enable_if_t<std::is_same_v<T, {intlike_t}>>>

{sig.decl(suppress_symint_suffix=True)} {{

return at::_ops::{f.func.name.unambiguous_name()}::call({exprs_str});

}}

}}

"""

return result

needs ScalarType.h, which needs to be header-only [ghstack-poisoned]

ghstack-source-id: ac037b9 Pull Request resolved: #159508

Add new_empty to torch::stable + dtype/scalar_type to stable::Tensor …

cbcdcfe

…(pending header-onlyness) [ghstack-poisoned]

This was referenced Jul 30, 2025

Update torch::stable::Tensor() default constructor #159507

Open

Add pad and narrow to torch/csrc/stable/ops.h #159328

Open

mikaylagawarecki added a commit that referenced this pull request Jul 30, 2025

Add new_empty to torch::stable + dtype/scalar_type to stable::Tensor …

2ec4dcd

…(pending header-onlyness) ghstack-source-id: 6cde171 Pull Request resolved: #159508

mikaylagawarecki mentioned this pull request Jul 31, 2025

[skip_ci] ABI stable fa3 Dao-AILab/flash-attention#1791

Draft

2 tasks

Update on "Add new_empty to torch::stable + dtype/scalar_type to stab…

6fced91

…le::Tensor (pending header-onlyness)" needs ScalarType.h, which needs to be header-only [ghstack-poisoned]

mikaylagawarecki added a commit that referenced this pull request Aug 4, 2025

Add new_empty to torch::stable + dtype/scalar_type to stable::Tensor …

90be175

…(pending header-onlyness) ghstack-source-id: b06a267 Pull Request resolved: #159508

Update on "Add new_empty to torch::stable + dtype/scalar_type to stab…

648adaa

…le::Tensor (pending header-onlyness)" needs ScalarType.h, which needs to be header-only [ghstack-poisoned]

mikaylagawarecki added a commit that referenced this pull request Aug 11, 2025

Add new_empty to torch::stable

0a80862

ghstack-source-id: 4c53a24 Pull Request resolved: #159508

pytorch-bot bot added ciflow/inductor release notes: inductor (aoti) labels Aug 11, 2025

mikaylagawarecki commented Aug 11, 2025

View reviewed changes

mikaylagawarecki changed the title ~~Add new_empty to torch::stable + dtype/scalar_type to stable::Tensor (pending header-onlyness)~~ Add new_empty (with dtype argument only) to torch::stable Aug 11, 2025

Update on "Add new_empty (with dtype argument only) to torch::stable"

ae40182

needs ScalarType.h, which needs to be header-only [ghstack-poisoned]

mikaylagawarecki added a commit that referenced this pull request Aug 11, 2025

Add new_empty to torch::stable

96d99d6

ghstack-source-id: ac037b9 Pull Request resolved: #159508

mikaylagawarecki marked this pull request as ready for review August 11, 2025 21:31

mikaylagawarecki requested a review from janeyx99 as a code owner August 11, 2025 21:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add new_empty (with dtype argument only) to torch::stable #159508

Add new_empty (with dtype argument only) to torch::stable #159508

mikaylagawarecki commented Jul 30, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented Jul 30, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 30, 2025

Uh oh!

mikaylagawarecki Aug 11, 2025

Uh oh!

Uh oh!

	if Variant.function in f.variants:
	result += f"""
	// aten::{f.func}
	inline {sig.decl()} {{
	return at::_ops::{f.func.name.unambiguous_name()}::call({exprs_str});
	}}"""

	# The template function can be used from template situations
	# where you want to switch between the symint or not version
	# depending on a template argument
	#
	# NB: we ALWAYS generate this even for methods. But we put it in
	# this header so it can take advantage of per-op headers
	if has_symint:
	result += f"""
	namespace symint {{
	template <typename T, typename = std::enable_if_t<std::is_same_v<T, {intlike_t}>>>
	{sig.decl(suppress_symint_suffix=True)} {{
	return at::_ops::{f.func.name.unambiguous_name()}::call({exprs_str});
	}}
	}}
	"""
	return result

Add new_empty (with dtype argument only) to torch::stable #159508

Are you sure you want to change the base?

Add new_empty (with dtype argument only) to torch::stable #159508

Conversation

mikaylagawarecki commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159508

❌ 4 New Failures

Uh oh!

github-actions bot commented Jul 30, 2025

This PR needs a release notes: label

Uh oh!

mikaylagawarecki Aug 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mikaylagawarecki commented Jul 30, 2025 •

edited

Loading

pytorch-bot bot commented Jul 30, 2025 •

edited

Loading

This PR needs a `release notes:` label