Skip to content

[inductor] dont reuse buffers if it affects peak (#145883) #159530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: gh/v0i0/4/base
Choose a base branch
from
Open

[inductor] dont reuse buffers if it affects peak (#145883) #159530

wants to merge 11 commits into from

Conversation

v0i0
Copy link
Contributor

@v0i0 v0i0 commented Jul 30, 2025 •
edited by pytorch-bot bot
Loading

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 30, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159530

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 8aa57d3 with merge base 2507ae6 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

  • pull / linux-jammy-py3_9-clang9-xla / test (xla, 1, 1, lf.linux.12xlarge, unstable) (gh) (#158876)
    /var/lib/jenkins/workspace/xla/torch_xla/csrc/runtime/BUILD:476:14: Compiling torch_xla/csrc/runtime/xla_util_test.cpp failed: (Exit 1): gcc failed: error executing CppCompile command (from target //torch_xla/csrc/runtime:xla_util_test) /usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG -ffunction-sections ... (remaining 229 arguments skipped)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

v0i0 added a commit that referenced this pull request Jul 30, 2025
@v0i0
[inductor] dont reuse buffers if it affects peak (#145883)
ecdb9ec 
ghstack-source-id: bfdb45a
Pull Request resolved: #159530
@v0i0
Copy link
Contributor Author

v0i0 commented Jul 30, 2025

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jul 30, 2025
@v0i0 v0i0 requested a review from eellison July 30, 2025 23:43
eellison
eellison reviewed Jul 31, 2025
View reviewed changes
@v0i0
Update on "[inductor] dont reuse buffers if it affects peak (#145883)"
fee1189 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben

[ghstack-poisoned]
v0i0 added a commit that referenced this pull request Jul 31, 2025
@v0i0
[inductor] dont reuse buffers if it affects peak (#145883)
79dba1d 
ghstack-source-id: 0a8f049
Pull Request resolved: #159530
@v0i0
Update on "[inductor] dont reuse buffers if it affects peak (#145883)"
ef0a1b8 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben

[ghstack-poisoned]
v0i0 added a commit that referenced this pull request Jul 31, 2025
@v0i0
[inductor] dont reuse buffers if it affects peak (#145883)
aa4878d 
ghstack-source-id: caae545
Pull Request resolved: #159530
@v0i0
Update on "[inductor] dont reuse buffers if it affects peak (#145883)"
7321ef6 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben

[ghstack-poisoned]
v0i0 added a commit that referenced this pull request Aug 2, 2025
@v0i0
[inductor] dont reuse buffers if it affects peak (#145883)
880f6a1 
ghstack-source-id: 26fbe62
Pull Request resolved: #159530
@v0i0
Update
a5bd343 
[ghstack-poisoned]
v0i0 added a commit that referenced this pull request Aug 5, 2025
@v0i0
[inductor] dont reuse buffers if it affects peak (#145883)
e52e66d 
ghstack-source-id: 74f2dec
Pull Request resolved: #159530
@v0i0
Update on "[inductor] dont reuse buffers if it affects peak (#145883)"
43f768d 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben

[ghstack-poisoned]
v0i0 added a commit that referenced this pull request Aug 7, 2025
@v0i0
[inductor] dont reuse buffers if it affects peak (#145883)
fe19796 
ghstack-source-id: 0178bf6
Pull Request resolved: #159530
@v0i0
Update on "[inductor] dont reuse buffers if it affects peak (#145883)"
c88ba1f 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben

[ghstack-poisoned]
v0i0 added a commit that referenced this pull request Aug 7, 2025
@v0i0
[inductor] dont reuse buffers if it affects peak (#145883)
10f50c4 
ghstack-source-id: 1b81d20
Pull Request resolved: #159530
@v0i0
Update on "[inductor] dont reuse buffers if it affects peak (#145883)"
3b6b12d 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben

[ghstack-poisoned]
v0i0 added a commit that referenced this pull request Aug 7, 2025
@v0i0
[inductor] dont reuse buffers if it affects peak (#145883)
f29e41c 
ghstack-source-id: a220714
Pull Request resolved: #159530
@v0i0
Update on "[inductor] dont reuse buffers if it affects peak (#145883)"
50ac986 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben

[ghstack-poisoned]
v0i0 added a commit that referenced this pull request Aug 7, 2025
@v0i0
[inductor] dont reuse buffers if it affects peak (#145883)
8277b8a 
ghstack-source-id: a632bb5
Pull Request resolved: #159530
@eellison eellison self-requested a review August 11, 2025 23:16
eellison
eellison reviewed Aug 11, 2025
View reviewed changes
Copy link
Contributor

@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, a couple questions about the tree. would you mind doing one dashboard run ? I believe we expect to see memory improvmenets in timm benchmark.

@v0i0
Copy link
Contributor Author

v0i0 commented Aug 12, 2025

Dashboard run here: https://github.com/pytorch/pytorch/actions/runs/16895400336

@v0i0
Update on "[inductor] dont reuse buffers if it affects peak (#145883)"
45698e2 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben

[ghstack-poisoned]
v0i0 added a commit that referenced this pull request Aug 12, 2025
@v0i0
[inductor] dont reuse buffers if it affects peak (#145883)
182d036 
ghstack-source-id: d2c153f
Pull Request resolved: #159530
eellison
eellison reviewed Aug 12, 2025
View reviewed changes
@v0i0
Copy link
Contributor Author

v0i0 commented Aug 12, 2025

dashboard run result

@v0i0
Update
8aa57d3 
[ghstack-poisoned]
v0i0 added a commit that referenced this pull request Aug 12, 2025
@v0i0
[inductor] dont reuse buffers if it affects peak (#145883)
7d10f99 
ghstack-source-id: 5c8aac4
Pull Request resolved: #159530
eellison
eellison approved these changes Aug 12, 2025
View reviewed changes
Copy link
Contributor

@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wooooo

@v0i0
Copy link
Contributor Author

v0i0 commented Aug 12, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 12, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 7d10f991106444131f03b0a7387f90292f84ec5a returned non-zero exit code 1

Auto-merging test/inductor/test_torchinductor.py
CONFLICT (content): Merge conflict in test/inductor/test_torchinductor.py
Auto-merging torch/_inductor/codegen/wrapper.py
Auto-merging torch/_inductor/scheduler.py
error: could not apply 7d10f991106... [inductor] dont reuse buffers if it affects peak (#145883)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Details for Dev Infra team Raised by workflow job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eellison eellison eellison approved these changes

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request module: inductor topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v0i0 @pytorchmergebot @eellison