fixes #156701 #159715
fixes #156701 #159715
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159715
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit a20239b with merge base 09e5a93 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Attention! native_functions.yaml was changedIf you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info. Caused by: |
test/fx/test_cse_pass.py
Outdated
| return a + b | ||
|
|
||
| # Test 2: Deterministic behavior using generator | ||
| def f_with_generator(x): |
There was a problem hiding this comment.
Hello, this method seems not invoked in this test. :D
|
@pytorchbot label "topic: not user facing" |
|
This makes me nervous for BC purposes, I think many of our generator overloads have dedicated generator overloads and that would be safer |
fixes #156701
cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv