Skip to content

Build and Install Arm Compute Library in manylinux docker image #159737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: gh/robert-hardwick/1/base
Choose a base branch
from
Open

Build and Install Arm Compute Library in manylinux docker image #159737

wants to merge 3 commits into from

Conversation

robert-hardwick
Copy link
Collaborator

@robert-hardwick robert-hardwick commented Aug 3, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

This PR will be part of a series of PR's that aims to remove .ci/aarch64_linux folder entirely, such that Aarch64 manylinux build happens as part of .ci/manywheel/build.sh, the same as other platforms.

In this PR:

  • We prebuild + install Arm Compute Library in the manylinux docker image ( at /acl ), instead of a build time for every pytorch build. Also updated jammy install path to be /acl too.
  • We can therefore remove build_ArmComputeLibrary functions from the ci build scripts.
  • There is also some refactoring of install_openblas.sh and install_acl.sh to align them together ( similar formatting, similar variable names, same place for version number update )
  • We had 2 places to define openblas version, this has been reduced to 1 now ( install_openblas.sh ).
  • ACL_VERSION and OPENBLAS_VERSION are now able to be overriden at build.sh level for developers, but there is only 1 version of each hardcoded for ci.

cc @seemethere @malfet @pytorch/pytorch-dev-infra @snadampal @milpuz01 @aditew01 @nikhil-arm @fadara01

@robert-hardwick
Update
50baacb 
[ghstack-poisoned]
@robert-hardwick robert-hardwick requested review from jeffdaily and a team as code owners August 3, 2025 22:18
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 3, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159737

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit 0704428 with merge base 9a680e1 (image):

UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: releng release notes category label Aug 3, 2025
robert-hardwick added a commit that referenced this pull request Aug 3, 2025
@robert-hardwick
Remove build_ArmComputeLibrary script from .ci/aarch64_linux/aarch64_…
1ce0981 
…wheel_ci_build.py

- Refactor install_acl and install_openblas to be more aligned.
- Arm Compute Library installs in manylinux docker image at /acl


ghstack-source-id: 0858356
Pull-Request: #159737
@robert-hardwick
Copy link
Collaborator Author

@pytorchbot label "ciflow/linux-aarch64"

@pytorch-bot pytorch-bot bot added the ciflow/linux-aarch64 linux aarch64 CI workflow label Aug 3, 2025
@robert-hardwick
Copy link
Collaborator Author

@malfet is anyone using https://github.com/pytorch/pytorch/blob/main/.ci/aarch64_linux/build_aarch64_wheel.py ? I notice the docker image is still configued to manylinux2014

pytorch/.ci/aarch64_linux/build_aarch64_wheel.py

Line 148 in e2a5c42

def start_docker(self, image="quay.io/pypa/manylinux2014_aarch64:latest") -> None:
which implies isn't not used much, or at least not maintained? I've tried to make the necessary changes to keep it working, but if we want to remove the .ci/aarch64_linux folder entirely, not sure what happens to this script.

@robert-hardwick robert-hardwick changed the title Remove build_ArmComputeLibrary script from .ci/aarch64_linux/aarch64_wheel_ci_build.py Remove build_ArmComputeLibrary script from .ci/aarch64_linux/aarch64_wheel_ci_build.py ( + install ACL in docker image ) Aug 3, 2025
@robert-hardwick robert-hardwick changed the title Remove build_ArmComputeLibrary script from .ci/aarch64_linux/aarch64_wheel_ci_build.py ( + install ACL in docker image ) Install Arm Compute Library in manylinx docker image Aug 3, 2025
@robert-hardwick robert-hardwick changed the title Install Arm Compute Library in manylinx docker image Build and Install Arm Compute Library in manylinux docker image Aug 3, 2025
@robert-hardwick
Update
b3698ad 
[ghstack-poisoned]
robert-hardwick added a commit that referenced this pull request Aug 4, 2025
@robert-hardwick
Remove build_ArmComputeLibrary script from .ci/aarch64_linux/aarch64_…
f530ca0 
…wheel_ci_build.py

- Refactor install_acl and install_openblas to be more aligned.
- Arm Compute Library installs in manylinux docker image at /acl

ghstack-source-id: 7f70101
Pull-Request: #159737
@robert-hardwick robert-hardwick added module: ci Related to continuous integration module: arm Related to ARM architectures builds of PyTorch. Includes Apple M1 labels Aug 5, 2025
@robert-hardwick
Update
0704428 
[ghstack-poisoned]
This was referenced Aug 7, 2025
Open
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

@malfet malfet Awaiting requested review from malfet

@aditew01 aditew01 Awaiting requested review from aditew01

Assignees
No one assigned
Labels
ciflow/linux-aarch64 linux aarch64 CI workflow module: arm Related to ARM architectures builds of PyTorch. Includes Apple M1 module: ci Related to continuous integration open source release notes: releng release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robert-hardwick @pytorchbot