AOT graph capture with dynamo. #159749
Open
AOT graph capture with dynamo. #159749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159749
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit ff51ba0 with merge base ba37f58 ( NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D79534608 |
ezyang
reviewed
Aug 4, 2025
| def _backend(gm, example_inputs): | ||
| from torch._guards import TracingContext | ||
| artifacts.backend_inputs[gm._backend_id] = BackendInput(gm, example_inputs, TracingContext.get().fake_mode) | ||
| return gm |
There was a problem hiding this comment.
I would prefer for us to NOT actually implement it this way (I want to directly call into convert_frame and bypass the eval frame handler entirely)
There was a problem hiding this comment.
Yeah I can imagine this may be shadowed by some global context if we dont bypass eval frame things, is this the main issue? how do we get the frame object to feed to convert_frame if we bypass eval_frame, maybe sys.settrace()?
ezyang
reviewed
Aug 4, 2025
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 4, 2025
Summary: Following up on Avik's doc https://docs.google.com/document/d/11RW0Bbkp1QwFbEu8rCNW5d7wUFaEkxbL0uLyqcc2jTk/edit?tab=t.0 We are experimenting with a new API which utilizes torch.compile(fullgraph=True) and intend to use it to replace the old dynamo.export() API. This PR adds a prototype for the API described in the doc. Test Plan: test_misc -- -k test_aot_capture Rollback Plan: Differential Revision: D79534608
dd2c00a to
e4f60fb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79534608 |
Summary: Following up on Avik's doc https://docs.google.com/document/d/11RW0Bbkp1QwFbEu8rCNW5d7wUFaEkxbL0uLyqcc2jTk/edit?tab=t.0 We are experimenting with a new API which utilizes torch.compile(fullgraph=True) and intend to use it to replace the old dynamo.export() API. This PR adds a prototype for the API described in the doc. Test Plan: test_misc -- -k test_aot_capture Rollback Plan: Differential Revision: D79534608
e4f60fb to
ff51ba0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79534608 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Following up on Avik's doc https://docs.google.com/document/d/11RW0Bbkp1QwFbEu8rCNW5d7wUFaEkxbL0uLyqcc2jTk/edit?tab=t.0
We are experimenting with a new API which utilizes torch.compile(fullgraph=True) and intend to use it to replace the old dynamo.export() API.
This PR adds a prototype for the API described in the doc.
Test Plan:
test_misc -- -k test_aot_capture
Rollback Plan:
Differential Revision: D79534608
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela