Skip to content

[Inductor][Triton] Support TMA before strict 3.4 cutoff #159777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Inductor][Triton] Support TMA before strict 3.4 cutoff #159777

wants to merge 1 commit into from

Conversation

njriasan
Copy link
Contributor

@njriasan njriasan commented Aug 4, 2025 •
edited by pytorch-bot bot
Loading

Summary: Inductor's 3.4 Triton release is the most common used variant of Triton, but if someone is working with an alternative version of Triton this may not match. This moves the version check from 3.4 Triton to any variant that has support for the TMA APIs.

Test Plan:
Relying on CI. Should be a NFC.

Rollback Plan:

Reviewed By: davidberard98

Differential Revision: D79378792

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 4, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159777

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 1 Unrelated Failure

As of commit 4d92666 with merge base a7f3bdf (image):

NEW FAILURE - The following job has failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

  • pull / linux-jammy-py3_9-clang9-xla / test (xla, 1, 1, lf.linux.12xlarge, unstable) (gh) (#158876)
    /var/lib/jenkins/workspace/xla/torch_xla/csrc/runtime/BUILD:476:14: Compiling torch_xla/csrc/runtime/xla_util_test.cpp failed: (Exit 1): gcc failed: error executing CppCompile command (from target //torch_xla/csrc/runtime:xla_util_test) /usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG -ffunction-sections ... (remaining 229 arguments skipped)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D79378792

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D79378792

njriasan added a commit to njriasan/pytorch that referenced this pull request Aug 4, 2025
@njriasan @facebook-github-bot
[Inductor][Triton] Support TMA before strict 3.4 cutoff (pytorch#159777)
f62fea1 
Summary:
Pull Request resolved: pytorch#159777

Inductor's 3.4 Triton release is the most common used variant of Triton, but if someone is working with an alternative version of Triton this may not match. This moves the version check from 3.4 Triton to any variant that has support for the TMA APIs.

Test Plan:
Relying on CI. Should be a NFC.

Rollback Plan:

Reviewed By: davidberard98

Differential Revision: D79378792
@njriasan njriasan added the topic: not user facing topic category label Aug 4, 2025
@njriasan njriasan requested a review from davidberard98 August 4, 2025 17:53
davidberard98
davidberard98 approved these changes Aug 4, 2025
View reviewed changes
Copy link
Contributor

@davidberard98 davidberard98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it needs to be linted, otherwise lgtm & thanks for the fix!

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 4, 2025
njriasan added a commit to njriasan/pytorch that referenced this pull request Aug 4, 2025
@njriasan @facebook-github-bot
[Inductor][Triton] Support TMA before strict 3.4 cutoff (pytorch#159777)
835199e 
Summary:

Inductor's 3.4 Triton release is the most common used variant of Triton, but if someone is working with an alternative version of Triton this may not match. This moves the version check from 3.4 Triton to any variant that has support for the TMA APIs.

Test Plan:
Relying on CI. Should be a NFC.

Rollback Plan:

Reviewed By: davidberard98

Differential Revision: D79378792
@njriasan @facebook-github-bot
[Inductor][Triton] Support TMA before strict 3.4 cutoff (pytorch#159777)
4d92666 
Summary:
Pull Request resolved: pytorch#159777

Inductor's 3.4 Triton release is the most common used variant of Triton, but if someone is working with an alternative version of Triton this may not match. This moves the version check from 3.4 Triton to any variant that has support for the TMA APIs.

Test Plan:
Relying on CI. Should be a NFC.

Rollback Plan:

Reviewed By: davidberard98

Differential Revision: D79378792
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D79378792

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@jithunnair-amd jithunnair-amd added the ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 label Aug 5, 2025
@izaitsevfb
Copy link
Contributor

@pytorchbot revert -m "breaking inductor test on ROCm" -c nosignal

FAILED [2.6870s] inductor/test_torchinductor_strided_blocks.py::TritonTensorDescriptorTestCUDA::test_welford_non_block_pointer_cuda - AssertionError: Scalars are not equal!
caused by this PR:
https://github.com/pytorch/pytorch/pull/159777
[Inductor][Triton] Support TMA before strict 3.4 cutoff #159777

hud link:
https://hud.pytorch.org/hud/pytorch/pytorch/main/1?per_page=50&name_filter=rocm%20%2F&mergeEphemeralLF=true

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@njriasan your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Aug 5, 2025
@pytorchmergebot
Revert "[Inductor][Triton] Support TMA before strict 3.4 cutoff (#159777
4108127 
)"

This reverts commit bbc0df1.

Reverted #159777 on behalf of https://github.com/izaitsevfb due to breaking inductor test on ROCm ([comment](#159777 (comment)))
@pytorchmergebot pytorchmergebot added the ci-no-td Do not run TD on this PR label Aug 5, 2025
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -i

(Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: rocm-mi300 / linux-noble-rocm-py3.12-mi300 / test (default, 3, 6, linux.rocm.gpu.gfx942.2)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: Meta Internal-Only Changes Check

Details for Dev Infra team Raised by workflow job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidberard98 davidberard98 davidberard98 approved these changes

Assignees
No one assigned
Labels
ci-no-td Do not run TD on this PR ciflow/inductor ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged module: inductor Reverted topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@njriasan @facebook-github-bot @pytorchmergebot @izaitsevfb @davidberard98 @jithunnair-amd