Skip to content

[Caffe2] Add float batch box cox SVE128 implementation #159778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Nicoshev
Copy link
Contributor

@Nicoshev Nicoshev commented Aug 4, 2025

Summary:
We are introducing SVE128 perfkernels

As first translation, we are implementing float32 batch box cox for SVE128

Test Plan:
Sigrid Predictor canary

Rollback Plan:

Differential Revision:
D78994871

Privacy Context Container: L1196524

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @jerryzh168 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben

Copy link

pytorch-bot bot commented Aug 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159778

Note: Links to docs will display an error until the docs builds have been completed.

❌ 8 New Failures

As of commit 1835a92 with merge base bfc873d (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link

linux-foundation-easycla bot commented Aug 4, 2025

CLA Missing ID CLA Not Signed

@pytorch-bot pytorch-bot bot added ciflow/inductor module: cpu CPU specific problem (e.g., perf, algorithm) module: inductor release notes: sparse release notes category labels Aug 4, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78994871

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78994871

Nicoshev added a commit to Nicoshev/pytorch that referenced this pull request Aug 5, 2025
Summary:
Pull Request resolved: pytorch#159778

We are introducing SVE128 perfkernels

As first translation, we are implementing float32 batch box cox for SVE128

Test Plan:
Sigrid Predictor canary

Rollback Plan:

Differential Revision:
D78994871

Privacy Context Container: L1196524
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78994871

Nicoshev added a commit to Nicoshev/pytorch that referenced this pull request Aug 5, 2025
Summary:
Pull Request resolved: pytorch#159778

We are introducing SVE128 perfkernels

As first translation, we are implementing float32 batch box cox for SVE128

Test Plan:
Sigrid Predictor canary

Rollback Plan:

Differential Revision:
D78994871

Privacy Context Container: L1196524
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78994871

Nicoshev added a commit to Nicoshev/pytorch that referenced this pull request Aug 5, 2025
Summary:
Pull Request resolved: pytorch#159778

We are introducing SVE128 perfkernels

As first translation, we are implementing float32 batch box cox for SVE128

Test Plan:
Sigrid Predictor canary

Rollback Plan:

Differential Revision:
D78994871

Privacy Context Container: L1196524
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78994871

Nicoshev added a commit to Nicoshev/pytorch that referenced this pull request Aug 5, 2025
Summary:
Pull Request resolved: pytorch#159778

We are introducing SVE128 perfkernels

As first translation, we are implementing float32 batch box cox for SVE128

Test Plan:
Sigrid Predictor canary

Rollback Plan:

Differential Revision:
D78994871

Privacy Context Container: L1196524
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78994871

Nicoshev added a commit to Nicoshev/pytorch that referenced this pull request Aug 5, 2025
Summary:
Pull Request resolved: pytorch#159778

We are introducing SVE128 perfkernels

As first translation, we are implementing float32 batch box cox for SVE128

Test Plan:
Sigrid Predictor canary

Rollback Plan:

Differential Revision:
D78994871

Privacy Context Container: L1196524
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78994871

Nicoshev added a commit to Nicoshev/pytorch that referenced this pull request Aug 5, 2025
Summary:
Pull Request resolved: pytorch#159778

We are introducing SVE128 perfkernels

As first translation, we are implementing float32 batch box cox for SVE128

Test Plan:
Sigrid Predictor canary

Rollback Plan:

Differential Revision:
D78994871

Privacy Context Container: L1196524
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78994871

pytorch-bot bot pushed a commit that referenced this pull request Aug 6, 2025
Summary:
Pull Request resolved: #159778

We are introducing SVE128 perfkernels

As first translation, we are implementing float32 batch box cox for SVE128

Test Plan:
Sigrid Predictor canary

Rollback Plan:

Differential Revision:
D78994871

Privacy Context Container: L1196524
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78994871

Nicoshev added a commit to Nicoshev/pytorch that referenced this pull request Aug 7, 2025
Summary:
Pull Request resolved: pytorch#159778

We are introducing SVE128 perfkernels

As first translation, we are implementing float32 batch box cox for SVE128

Test Plan:
Sigrid Predictor canary

Rollback Plan:

Differential Revision:
D78994871

Privacy Context Container: L1196524
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78994871

Nicoshev added a commit to Nicoshev/pytorch that referenced this pull request Aug 8, 2025
Summary:
Pull Request resolved: pytorch#159778

We are introducing SVE128 perfkernels

As first translation, we are implementing float32 batch box cox for SVE128

Test Plan:
Sigrid Predictor canary

Rollback Plan:

Differential Revision:
D78994871

Privacy Context Container: L1196524
Summary:
Pull Request resolved: pytorch#158932

Importing pytorch#138388, as it improves SVE support for perfkernels

Test Plan: We will test it on AdFinder/AdRetriever/AdRanker offline tier

Differential Revision: D70788867

Reviewed By: r1mikey
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78994871

pytorch-bot bot pushed a commit that referenced this pull request Aug 9, 2025
Summary:
Pull Request resolved: #159778

We are introducing SVE128 perfkernels

As first translation, we are implementing float32 batch box cox for SVE128

Test Plan:
Sigrid Predictor canary

Rollback Plan:

Differential Revision:
D78994871

Privacy Context Container: L1196524
Summary: Enabling compilation targeting SVE128

Test Plan: AdRanker/AdFinder ServiceLab

Differential Revision: D78691521
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78994871

Nicoshev added a commit to Nicoshev/pytorch that referenced this pull request Aug 11, 2025
Summary:
Pull Request resolved: pytorch#159778

We are introducing SVE128 perfkernels

As first translation, we are implementing float32 batch box cox for SVE128

Test Plan:
Sigrid Predictor canary

Rollback Plan:

Differential Revision:
D78994871

Privacy Context Container: L1196524
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78994871

Nicoshev added a commit to Nicoshev/pytorch that referenced this pull request Aug 11, 2025
Summary:
Pull Request resolved: pytorch#159778

We are introducing SVE128 perfkernels

As first translation, we are implementing float32 batch box cox for SVE128

Test Plan:
Sigrid Predictor canary

Rollback Plan:

Differential Revision:
D78994871

Privacy Context Container: L1196524
Nicolas De Carli and others added 2 commits August 11, 2025 20:01
Summary:
We are introducing the SVE128 vectorized<> layer.

Idea is to differentiate SVE128 perfkernels from the general SVE implementation

Mixing NEON and SVE should maximize performance on SVE128 cpus

Test Plan: Sigrid Predictor canary

Differential Revision: D78902495
Summary:
Pull Request resolved: pytorch#159778

We are introducing SVE128 perfkernels

As first translation, we are implementing float32 batch box cox for SVE128

Test Plan:
Sigrid Predictor canary

Rollback Plan:

Differential Revision:
D78994871

Privacy Context Container: L1196524
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78994871

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/inductor fb-exported module: cpu CPU specific problem (e.g., perf, algorithm) module: inductor release notes: sparse release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants