Skip to content

[dynamo][guards] Install dict watchers for recrusive dict tag optimization #159796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 22 commits into
base: gh/anijain2305/843/base
Choose a base branch
from

Conversation

anijain2305
Copy link
Contributor

@anijain2305 anijain2305 commented Aug 4, 2025

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Aug 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159796

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 55 Pending

As of commit dccc696 with merge base 8d3d1c8 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

anijain2305 added a commit that referenced this pull request Aug 4, 2025
@anijain2305 anijain2305 added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Aug 4, 2025
[ghstack-poisoned]
[ghstack-poisoned]
anijain2305 added a commit that referenced this pull request Aug 5, 2025
[ghstack-poisoned]
anijain2305 added a commit that referenced this pull request Aug 5, 2025
[ghstack-poisoned]
[ghstack-poisoned]
anijain2305 added a commit that referenced this pull request Aug 5, 2025
[ghstack-poisoned]
anijain2305 added a commit that referenced this pull request Aug 5, 2025
[ghstack-poisoned]
[ghstack-poisoned]
anijain2305 added a commit that referenced this pull request Aug 7, 2025
[ghstack-poisoned]
[ghstack-poisoned]
anijain2305 added a commit that referenced this pull request Aug 8, 2025
[ghstack-poisoned]
anijain2305 added a commit that referenced this pull request Aug 8, 2025
[ghstack-poisoned]
anijain2305 added a commit that referenced this pull request Aug 8, 2025
…tag optimization"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]
anijain2305 added a commit that referenced this pull request Aug 9, 2025
[ghstack-poisoned]
anijain2305 added a commit that referenced this pull request Aug 10, 2025
anijain2305 added a commit that referenced this pull request Aug 10, 2025
[ghstack-poisoned]
anijain2305 added a commit that referenced this pull request Aug 10, 2025
[ghstack-poisoned]
anijain2305 added a commit that referenced this pull request Aug 10, 2025
[ghstack-poisoned]
anijain2305 added a commit that referenced this pull request Aug 11, 2025
[ghstack-poisoned]
anijain2305 added a commit that referenced this pull request Aug 11, 2025
PyObject* key,
PyObject* new_value) noexcept {
auto it = dict_to_guard_managers.find(dict);
if (it != dict_to_guard_managers.end()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we avoid doing this if the event is PyDict_EVENT_CLONED since that shouldn't mutate the dict?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add it yeah.

[ghstack-poisoned]
anijain2305 added a commit that referenced this pull request Aug 12, 2025
[ghstack-poisoned]
anijain2305 added a commit that referenced this pull request Aug 12, 2025
@anijain2305
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-no-td Do not run TD on this PR ciflow/inductor ciflow/slow ciflow/trunk Trigger trunk jobs on your pull request merging module: dynamo topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants