-
Notifications
You must be signed in to change notification settings - Fork 24.9k
[dynamo][guards] Install dict watchers for recrusive dict tag optimization #159796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh/anijain2305/843/base
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159796
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 55 PendingAs of commit dccc696 with merge base 8d3d1c8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…tag optimization" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
torch/csrc/dynamo/guards.cpp
Outdated
PyObject* key, | ||
PyObject* new_value) noexcept { | ||
auto it = dict_to_guard_managers.find(dict); | ||
if (it != dict_to_guard_managers.end()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we avoid doing this if the event is PyDict_EVENT_CLONED
since that shouldn't mutate the dict?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add it yeah.
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela