fix type documentation for context_parallel no_restore_buffers, to prevent user from passing in the wrong type #159808
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you pass in a list, such as in the following testcase, you'll receive
RuntimeError: Boolean value of Tensor with more than one value is ambiguous
:Changing
no_restore_buffers=cp_qkv
tono_restore_buffers=set(cp_qkv)
fixes it.Another viable option is to reject this patch and instead change
no_restore_buffers = set() if no_restore_buffers is None else no_restore_buffers
tono_restore_buffers = set() if no_restore_buffers is None else set(no_restore_buffers)
. Other users are likely to make the same mistake of passing in a list.I assume "b in list" is doing a tensor-wise truth comparison, while "b in set" is somehow not.
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta