Replace C array with std::array in formatSockAddr #159812
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159812
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 3 Unrelated FailuresAs of commit 2818676 with merge base 908c5cc ( NEW FAILURES - The following jobs have failed:
UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
cc Skylion007 cc H-Huang awgu wanchaol fegin fduwjj wz337 d4l3k pragupta [ghstack-poisoned]
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 3 checks: Check mergeability of ghstack PR / ghstack-mergeability-check, Check Labels / Check labels, pull / linux-jammy-py3_9-clang9-xla / test (xla, 1, 1, lf.linux.12xlarge, unstable) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m "Looks like it broke distribtued tests, see https://hud.pytorch.org/hud/pytorch/pytorch/2231c3ca3a25529115610d8215ee5601c4c8ee89/1?per_page=50&name_filter=distributed" -c nosignal |
|
@pytorchbot successfully started a revert job. Check the current status here. |
This reverts commit e7feedf. Reverted #159812 on behalf of https://github.com/malfet due to Looks like it broke distribtued tests, see https://hud.pytorch.org/hud/pytorch/pytorch/2231c3ca3a25529115610d8215ee5601c4c8ee89/1?per_page=50&name_filter=distributed ([comment](#159812 (comment)))
|
@wconstab your PR has been successfully reverted. |
|
uh oh! glad i kept this 'simple refactor' separate from the actual PR i wanted to land 😅 |
Stack from ghstack (oldest at bottom):
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @d4l3k @pragupta @Skylion007
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @d4l3k @pragupta