Add support for error-ing when there is side effect #159826
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Previously in export, we ignored side-effect table from dynamo which can lead to incorrectness as shown in the test case. In this PR, we walk over remaining side effects and suggest where the user can look for. Test Plan: CI Rollback Plan: Differential Revision: D79607564
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159826
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 36 New Failures, 1 Unrelated FailureAs of commit 620071a with merge base e273ff0 ( NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D79607564 |
anijain2305
approved these changes
Aug 5, 2025
|
@pytorchbot label "topic: not user facing" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Previously in export, we ignored side-effect table from dynamo which can lead to incorrectness as shown in the test case. In this PR, we walk over remaining side effects and suggest where the user can look for.
Test Plan:
CI
Rollback Plan:
Differential Revision: D79607564
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela