Skip to content

fix link for tutorial of inductor on windows #159853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix link for tutorial of inductor on windows #159853

wants to merge 2 commits into from

Conversation

ZhaoqiongZ
Copy link
Collaborator

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159853

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (1 Unrelated Failure)

As of commit c31cf33 with merge base 09e5a93 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

  • pull / linux-jammy-py3_9-clang9-xla / test (xla, 1, 1, lf.linux.12xlarge, unstable) (gh) (#158876)
    /var/lib/jenkins/workspace/xla/torch_xla/csrc/runtime/BUILD:476:14: Compiling torch_xla/csrc/runtime/xla_util_test.cpp failed: (Exit 1): gcc failed: error executing CppCompile command (from target //torch_xla/csrc/runtime:xla_util_test) /usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG -ffunction-sections ... (remaining 229 arguments skipped)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ZhaoqiongZ ZhaoqiongZ mentioned this pull request Aug 5, 2025
Open
@ZhaoqiongZ
Copy link
Collaborator Author

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Aug 5, 2025
@ZhaoqiongZ
Copy link
Collaborator Author

Hi @svekars , I saw that you've rerange the structure of tutorials and make the link for tutorial update to https://docs.pytorch.org/tutorials/unstable/inductor_windows.html from https://docs.pytorch.org/tutorials/prototype/inductor_windows.html
Thus, I have to update the correct link in this doc to make it accessible.
Could you hlep review and merge it?

@ZhaoqiongZ ZhaoqiongZ requested a review from Copilot August 5, 2025 08:58
Copilot
Copilot AI reviewed Aug 5, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a broken documentation link that was outdated due to a recent structural change in the PyTorch tutorials repository. The link previously pointed to the prototype directory but now needs to point to the unstable directory.

  • Updates the URL path from /prototype/ to /unstable/ for the Inductor Windows tutorial

zeshengzong
zeshengzong reviewed Aug 5, 2025
View reviewed changes
@sekyondaMeta @zeshengzong
Update docs/source/notes/get_start_xpu.rst
c31cf33 
Co-authored-by: Zesheng Zong <zesheng.zong@outlook.com>
sekyondaMeta
sekyondaMeta approved these changes Aug 5, 2025
View reviewed changes
Copy link
Collaborator

@sekyondaMeta sekyondaMeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM waiting on CI

@sekyondaMeta
Copy link
Collaborator

@pytorchbot merge -f "Doc change only. doc signal is green."

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

ZhaoqiongZ added a commit to ZhaoqiongZ/pytorch that referenced this pull request Aug 6, 2025
@ZhaoqiongZ @sekyondaMeta @zeshengzong
fix link for tutorial of inductor on windows (pytorch#159853)
dab3b0e 
fix link issue from https://docs.pytorch.org/tutorials/prototype/inductor_windows.html to https://docs.pytorch.org/tutorials/unstable/inductor_windows.html due to structure change with pr pytorch/tutorials#3489
Pull Request resolved: pytorch#159853
Approved by: https://github.com/sekyondaMeta

Co-authored-by: sekyondaMeta <127536312+sekyondaMeta@users.noreply.github.com>
Co-authored-by: Zesheng Zong <zesheng.zong@outlook.com>
This was referenced Aug 6, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeshengzong zeshengzong zeshengzong left review comments

Copilot code review Copilot Copilot left review comments

@sekyondaMeta sekyondaMeta sekyondaMeta approved these changes

Assignees
No one assigned
Labels
Merged open source topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ZhaoqiongZ @sekyondaMeta @pytorchmergebot @zeshengzong @pytorchbot