-
Notifications
You must be signed in to change notification settings - Fork 24.9k
[Test][Easy] Use float16 dtype in test_sort_large #159939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159939
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 712d30f with merge base a53d14d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving assuming that this never ran before and therefore this is not a regression
Indeed, it never ran before. The only machine which has that much memory is GB300. |
Hmm, those are strange failures @pytorchbot rebase |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Successfully rebased |
a321cf0
to
712d30f
Compare
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
@Aidyn-A Did this updated test run in any of the CI jobs? It failed in ROCm CI (because the MI325 has >200GB memory) with the error |
Yes, it is passing on GB300. Was it passing prior my changes? I believe it should have failed, because |
The test fails with: >RuntimeError: var_mean only support floating point and complex dtypes Pull Request resolved: pytorch#159939 Approved by: https://github.com/eqy
The test fails with:
cc @ptrblck @msaroufim @eqy @jerryzh168