Skip to content

[Inductor] Add back the revert part #160054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Inductor] Add back the revert part #160054

wants to merge 1 commit into from

Conversation

andyanwang
Copy link
Contributor

@andyanwang andyanwang commented Aug 7, 2025 •
edited
Loading

Add back the reverted code(#159809) as we've figured out the actual root cause of the internal test failures. Mote details in the internal diff.
Rollback Plan:

Differential Revision: D79776691

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela @egienvalue

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 7, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160054

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d4d9714 with merge base 01f66d0 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D79776691

@andyanwang andyanwang added topic: not user facing topic category module: mtia Device MTIA related issues labels Aug 7, 2025
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 8, 2025
pytorch-bot bot pushed a commit that referenced this pull request Aug 8, 2025
@andyanwang @facebook-github-bot
[Inductor] Add back the reverted part, and resolve test failures by m…
2d02308 
…oving import (#160054)

Summary: Pull Request resolved: #160054

Reviewed By: blaine-rister

Differential Revision: D79776691
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D79776691

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -i

(Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 14 checks: pull / linux-jammy-py3.13-clang12 / test (dynamo_wrapped, 1, 3, lf.linux.2xlarge), pull / linux-jammy-py3.13-clang12 / test (dynamo_wrapped, 2, 3, lf.linux.2xlarge), pull / linux-jammy-py3.13-clang12 / test (dynamo_wrapped, 3, 3, lf.linux.2xlarge), pull / linux-jammy-py3.13-clang12 / test (einops, 1, 1, lf.linux.2xlarge), pull / linux-jammy-py3.13-clang12 / test (crossref, 1, 2, lf.linux.2xlarge), pull / linux-jammy-py3.13-clang12 / test (crossref, 2, 2, lf.linux.2xlarge), pull / linux-jammy-py3.9-clang12-onnx / test (default, 2, 2, lf.linux.2xlarge), pull / linux-jammy-py3.9-clang12-onnx / test (default, 1, 2, lf.linux.2xlarge), pull / linux-jammy-py3.9-clang12 / test (crossref, 2, 2, lf.linux.2xlarge), pull / linux-jammy-py3.9-clang12 / test (dynamo_wrapped, 3, 3, lf.linux.2xlarge), pull / linux-jammy-py3.9-clang12 / test (crossref, 1, 2, lf.linux.2xlarge), pull / linux-jammy-py3.9-clang12 / test (dynamo_wrapped, 1, 3, lf.linux.2xlarge), pull / linux-jammy-py3.9-clang12 / test (dynamo_wrapped, 2, 3, lf.linux.2xlarge), pull / linux-docs / build-docs-python-false

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 13 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@izaitsevfb
Copy link
Contributor

@pytorchbot merge -r

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@andyanwang @pytorchmergebot
[Inductor] Add back the reverted part, and resolve test failures by m…
d4d9714 
…oving import (pytorch#160054)

Summary: Pull Request resolved: pytorch#160054

Reviewed By: blaine-rister

Differential Revision: D79776691
@pytorchmergebot
Copy link
Collaborator

Successfully rebased export-D79776691 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout export-D79776691 && git pull --rebase)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blaine-rister blaine-rister blaine-rister approved these changes

@eellison eellison Awaiting requested review from eellison

Assignees
No one assigned
Labels
ci-no-td Do not run TD on this PR ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged module: dynamo module: mtia Device MTIA related issues topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andyanwang @facebook-github-bot @pytorchmergebot @izaitsevfb @blaine-rister