Fix get_free_symbol_uses for several nodes. #160134
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160134
Note: Links to docs will display an error until the docs builds have been completed. ❌ 9 New FailuresAs of commit 55d60f4 with merge base 5ed4f91 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D79826917 |
5514487 to
97430ba
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79826917 |
Summary: todo Test Plan: todo Rollback Plan: Differential Revision: D79826917
…OwningLayout , NopKernel , ConcarKernel, InputsKerenl (pytorch#160134) Summary: Pull Request resolved: pytorch#160134 Test Plan: todo Rollback Plan: Differential Revision: D79826917
97430ba to
82b25cd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79826917 |
82b25cd to
b72bb46
Compare
Summary: Pull Request resolved: pytorch#160134 Test Plan: todo Rollback Plan: Differential Revision: D79826917
Summary: Pull Request resolved: pytorch#160134 Test Plan: todo Rollback Plan: Differential Revision: D79826917
b72bb46 to
fa4d59a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79826917 |
Summary: Pull Request resolved: pytorch#160134 Test Plan: todo Rollback Plan: Differential Revision: D79826917
|
This pull request was exported from Phabricator. Differential Revision: D79826917 |
fa4d59a to
55d60f4
Compare
|
@pytorchbot merge -i "not related faluire pre exisiting" |
|
❌ 🤖 pytorchbot command failed: Try |
|
@pytorchbot merge -i |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 1 checks: Lint / lintrunner-noclang / linux-job Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m "No, those are not pre-existing, see https://hud.pytorch.org/hud/pytorch/pytorch/df55ec7d4b35f6d21691e9dd41c82f27de762948/1?per_page=50&name_filter=lint&mergeEphemeralLF=true" -c ignoredsignal |
|
@pytorchbot successfully started a revert job. Check the current status here. |
This reverts commit db78943. Reverted #160134 on behalf of https://github.com/malfet due to No, those are not pre-existing, see https://hud.pytorch.org/hud/pytorch/pytorch/df55ec7d4b35f6d21691e9dd41c82f27de762948/1?per_page=50&name_filter=lint&mergeEphemeralLF=true ([comment](#160134 (comment)))
|
@laithsakka your PR has been successfully reverted. |
|
cc: @clee2000 looks like this PR was a huge TD miss: i.e. previously it only complained about linter, but once landed (and reverted with no-td) it started to fail a number of jobs. |
|
replaced with #160314 |
|
replaced |
get_free_symbol_uses is used to know what unbacked symbols are used by a given node.
not having correct get_free_symbol_uses defined properly leads to :
Fix get_free_symbol_uses , NopKernel , ConcarKernel, InputsKerenl, external kernel.
for ComputedBuffer with NonOwningLayout its interesting case.
when layout is NonOwningLayout we need to access the actual view op base layout and use
detect symbols in it. Because when we codegen the ComputedBuffer we uses those symbols.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben