Add torchao to install_inductor_benchmark_deps cleanup stage #160191

robert-hardwick · 2025-08-08T14:38:07Z

It looks like torcho was missed from the cleanup during torchbench setup.

Stack from ghstack (oldest at bottom):

-> Add torchao to install_inductor_benchmark_deps cleanup stage #160191

Fixes #160188

cc @seemethere @malfet @pytorch/pytorch-dev-infra @snadampal @milpuz01 @aditew01 @nikhil-arm @fadara01

[ghstack-poisoned]

pytorch-bot · 2025-08-08T14:38:11Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160191

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 15 New Failures

As of commit 2f1347d with merge base 556e2a7 ():

NEW FAILURES - The following jobs have failed:

inductor-perf-nightly-aarch64 / linux-jammy-aarch64-py3.10-inductor / test (inductor_torchbench_perf_cpu_aarch64, 1, 15, linux.arm64.m7g.metal) (gh)
Process completed with exit code 1.
inductor-perf-nightly-aarch64 / linux-jammy-aarch64-py3.10-inductor / test (inductor_torchbench_perf_cpu_aarch64, 10, 15, linux.arm64.m7g.metal) (gh)
Process completed with exit code 1.
inductor-perf-nightly-aarch64 / linux-jammy-aarch64-py3.10-inductor / test (inductor_torchbench_perf_cpu_aarch64, 11, 15, linux.arm64.m7g.metal) (gh)
Process completed with exit code 1.
inductor-perf-nightly-aarch64 / linux-jammy-aarch64-py3.10-inductor / test (inductor_torchbench_perf_cpu_aarch64, 12, 15, linux.arm64.m7g.metal) (gh)
Process completed with exit code 1.
inductor-perf-nightly-aarch64 / linux-jammy-aarch64-py3.10-inductor / test (inductor_torchbench_perf_cpu_aarch64, 13, 15, linux.arm64.m7g.metal) (gh)
Process completed with exit code 1.
inductor-perf-nightly-aarch64 / linux-jammy-aarch64-py3.10-inductor / test (inductor_torchbench_perf_cpu_aarch64, 14, 15, linux.arm64.m7g.metal) (gh)
Process completed with exit code 1.
inductor-perf-nightly-aarch64 / linux-jammy-aarch64-py3.10-inductor / test (inductor_torchbench_perf_cpu_aarch64, 15, 15, linux.arm64.m7g.metal) (gh)
Process completed with exit code 1.
inductor-perf-nightly-aarch64 / linux-jammy-aarch64-py3.10-inductor / test (inductor_torchbench_perf_cpu_aarch64, 2, 15, linux.arm64.m7g.metal) (gh)
Process completed with exit code 1.
inductor-perf-nightly-aarch64 / linux-jammy-aarch64-py3.10-inductor / test (inductor_torchbench_perf_cpu_aarch64, 3, 15, linux.arm64.m7g.metal) (gh)
Process completed with exit code 1.
inductor-perf-nightly-aarch64 / linux-jammy-aarch64-py3.10-inductor / test (inductor_torchbench_perf_cpu_aarch64, 4, 15, linux.arm64.m7g.metal) (gh)
Process completed with exit code 1.
inductor-perf-nightly-aarch64 / linux-jammy-aarch64-py3.10-inductor / test (inductor_torchbench_perf_cpu_aarch64, 5, 15, linux.arm64.m7g.metal) (gh)
Process completed with exit code 1.
inductor-perf-nightly-aarch64 / linux-jammy-aarch64-py3.10-inductor / test (inductor_torchbench_perf_cpu_aarch64, 6, 15, linux.arm64.m7g.metal) (gh)
Process completed with exit code 1.
inductor-perf-nightly-aarch64 / linux-jammy-aarch64-py3.10-inductor / test (inductor_torchbench_perf_cpu_aarch64, 7, 15, linux.arm64.m7g.metal) (gh)
Process completed with exit code 1.
inductor-perf-nightly-aarch64 / linux-jammy-aarch64-py3.10-inductor / test (inductor_torchbench_perf_cpu_aarch64, 8, 15, linux.arm64.m7g.metal) (gh)
Process completed with exit code 1.
inductor-perf-nightly-aarch64 / linux-jammy-aarch64-py3.10-inductor / test (inductor_torchbench_perf_cpu_aarch64, 9, 15, linux.arm64.m7g.metal) (gh)
Process completed with exit code 1.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ghstack-source-id: fe8e46d Pull-Request: #160191

robert-hardwick · 2025-08-08T14:41:35Z

@pytorchbot label "ciflow/inductor-perf-nightly-aarch64"

pytorch-bot · 2025-08-08T14:41:43Z

Didn't find following labels among repository labels: ciflow/inductor-perf-nightly-aarch64

robert-hardwick · 2025-08-08T14:42:01Z

@pytorchbot label "topic: not user facing"

robert-hardwick · 2025-08-08T14:43:42Z

@pytorchbot label "ciflow/inductor-perf-test-nightly-aarch64"

pytorch-bot · 2025-08-08T14:43:50Z

Didn't find following labels among repository labels: ciflow/inductor-perf-test-nightly-aarch64

robert-hardwick · 2025-08-08T16:08:23Z

Looks like it has fixed the issue - > https://github.com/pytorch/pytorch/actions/runs/16833390878/job/47686603854

huydhn · 2025-08-08T17:02:53Z

.ci/docker/common/install_inductor_benchmark_deps.sh

@@ -48,4 +48,4 @@ install_huggingface
 install_timm

 # Clean up
-conda_run pip uninstall -y torch torchvision torchaudio triton
+conda_run pip uninstall -y torch torchvision torchaudio triton torchao


I just realize that there is one more permission error bug in this script. After installing TorchBench on line 37, the script runs under root as part of the Docker build, so another chown -R jenkins /opt/conda is needed similar to https://github.com/pytorch/pytorch/blob/main/.ci/docker/common/install_conda.sh#L21. This will fix the remaining error in this script

huydhn

Thank you for the fix! Uninstalling torchao is the right thing to do here. There is another permission bug from my comment, but feel free to fix it here together with this change, or I could submit another PR to fix it after this lands. It's up to you

huydhn · 2025-08-08T22:16:43Z

@pytorchbot merge -f 'Let land this to unblock #159291, I will submit a fix for the rest of these failures in a separate PR'

pytorchmergebot · 2025-08-08T22:18:16Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

…#160191) It looks like `torcho` was missed from the cleanup during torchbench setup. Fixes pytorch#160188 Pull Request resolved: pytorch#160191 Approved by: https://github.com/huydhn

robert-hardwick · 2025-08-09T14:31:38Z

Thank you for the fix! Uninstalling torchao is the right thing to do here. There is another permission bug from my comment, but feel free to fix it here together with this change, or I could submit another PR to fix it after this lands. It's up to you

Thanks for the approval and for merging @huydhn . I would have fixed the permissions in this PR, but we have a process to follow and it was Fri PM in UK, so I wouldn't be able to make the change until Monday, so better to merge as-is 👍

Update

2f1347d

[ghstack-poisoned]

robert-hardwick requested a review from jeffdaily as a code owner August 8, 2025 14:38

pytorch-bot bot added the topic: not user facing topic category label Aug 8, 2025

robert-hardwick added a commit that referenced this pull request Aug 8, 2025

Add torchao to install_inductor_benchmark_deps cleanup stage

42b0d8f

ghstack-source-id: fe8e46d Pull-Request: #160191

robert-hardwick added module: ci Related to continuous integration module: arm Related to ARM architectures builds of PyTorch. Includes Apple M1 labels Aug 8, 2025

pytorchbot added the open source label Aug 8, 2025

robert-hardwick added topic: bug fixes topic category arm priority labels Aug 8, 2025

huydhn reviewed Aug 8, 2025

View reviewed changes

huydhn approved these changes Aug 8, 2025

View reviewed changes

pytorchmergebot added the merging label Aug 8, 2025

pytorchmergebot added the Merged label Aug 8, 2025

pytorchmergebot closed this in 334ecbd Aug 8, 2025

pytorchmergebot removed the merging label Aug 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add torchao to install_inductor_benchmark_deps cleanup stage #160191

Add torchao to install_inductor_benchmark_deps cleanup stage #160191

Uh oh!

robert-hardwick commented Aug 8, 2025 •

edited by pytorch-bot bot

Loading

Uh oh!

pytorch-bot bot commented Aug 8, 2025 •

edited

Loading

Uh oh!

robert-hardwick commented Aug 8, 2025

Uh oh!

pytorch-bot bot commented Aug 8, 2025

Uh oh!

robert-hardwick commented Aug 8, 2025

Uh oh!

robert-hardwick commented Aug 8, 2025

Uh oh!

pytorch-bot bot commented Aug 8, 2025

Uh oh!

robert-hardwick commented Aug 8, 2025

Uh oh!

huydhn Aug 8, 2025

Uh oh!

huydhn left a comment

Uh oh!

huydhn commented Aug 8, 2025

Uh oh!

pytorchmergebot commented Aug 8, 2025

Uh oh!

robert-hardwick commented Aug 9, 2025

Uh oh!

Uh oh!

Add torchao to install_inductor_benchmark_deps cleanup stage #160191

Add torchao to install_inductor_benchmark_deps cleanup stage #160191

Uh oh!

Conversation

robert-hardwick commented Aug 8, 2025 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Aug 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160191

❌ 15 New Failures

Uh oh!

robert-hardwick commented Aug 8, 2025

Uh oh!

pytorch-bot bot commented Aug 8, 2025

Uh oh!

robert-hardwick commented Aug 8, 2025

Uh oh!

robert-hardwick commented Aug 8, 2025

Uh oh!

pytorch-bot bot commented Aug 8, 2025

Uh oh!

robert-hardwick commented Aug 8, 2025

Uh oh!

huydhn Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

huydhn left a comment

Choose a reason for hiding this comment

Uh oh!

huydhn commented Aug 8, 2025

Uh oh!

pytorchmergebot commented Aug 8, 2025

Merge started

Uh oh!

robert-hardwick commented Aug 9, 2025

Uh oh!

Uh oh!

robert-hardwick commented Aug 8, 2025 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Aug 8, 2025 •

edited

Loading