Skip to content

Create a new bionic image with clang9 #36187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Create a new bionic image with clang9 #36187

wants to merge 3 commits into from

Conversation

ailzhang
Copy link
Contributor

@ailzhang ailzhang commented Apr 8, 2020 •
edited
Loading

New images are already available at http://docker.pytorch.org/pytorch.html.

@ailzhang ailzhang changed the title Try switching docker image. [TEST]Try switching docker image. Apr 8, 2020
@dr-ci
Copy link

dr-ci bot commented Apr 8, 2020 •
edited
Loading

💊 Build failures summary and remediations

As of commit 8e8cb80 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

XLA failure

Job pytorch_xla_linux_xenial_py3_6_clang7_build is failing. Please create an issue with title prefixed by [PT_BREAK] in pytorch/xla and link to to this PR. If you have questions, please reach out to @ailzhang / @dlibenzi / @JackCaoG.

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 46 times.

@ailzhang ailzhang force-pushed the update_xla_ci branch 2 times, most recently from 00d35d0 to b2126af Compare April 8, 2020 02:16
@dlibenzi dlibenzi mentioned this pull request Apr 8, 2020
Closed
@ailzhang ailzhang force-pushed the update_xla_ci branch 3 times, most recently from 597eef0 to a70c11b Compare April 13, 2020 16:05
@ailzhang ailzhang changed the title [TEST]Try switching docker image. [TEST]Create a new bionic image with clang9 Apr 13, 2020
@ailzhang ailzhang force-pushed the update_xla_ci branch 2 times, most recently from 43fe862 to 8083234 Compare April 13, 2020 18:50
@ailzhang ailzhang changed the title [TEST]Create a new bionic image with clang9 Create a new bionic image with clang9 Apr 13, 2020
@ailzhang ailzhang requested a review from ezyang April 13, 2020 18:52
@ailzhang ailzhang removed the request for review from ezyang April 13, 2020 19:42
@ailzhang ailzhang changed the title Create a new bionic image with clang9 [WIP]Create a new bionic image with clang9 Apr 13, 2020
@ailzhang
Copy link
Contributor Author

Marked it as WIP since I realized that I didn't wait all 16 image build jobs finish...
redoing ...

@ailzhang ailzhang changed the title [WIP]Create a new bionic image with clang9 Create a new bionic image with clang9 Apr 14, 2020
facebook-github-bot
facebook-github-bot reviewed Apr 14, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ailzhang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ailzhang ailzhang requested review from ezyang and malfet April 14, 2020 15:42
malfet
malfet reviewed Apr 14, 2020
View reviewed changes
.circleci/verbatim-sources/workflows-ecr-gc.yml
@@ -10,7 +10,7 @@
- ecr_gc_job:
name: ecr_gc_job_for_pytorch
project: pytorch
tags_to_keep: "271,262,256,278,282,291,300,323,327,347,389,401,402,403,405,a8006f9a-272d-4478-b137-d121c6f05c83,6e7b11da-a919-49e5-b2ba-da66e3d4bb0a,f990c76a-a798-42bb-852f-5be5006f8026,e43973a9-9d5a-4138-9181-a08a0fc55e2f"
tags_to_keep: "271,262,256,278,282,291,300,323,327,347,389,401,402,403,405,a8006f9a-272d-4478-b137-d121c6f05c83,6e7b11da-a919-49e5-b2ba-da66e3d4bb0a,f990c76a-a798-42bb-852f-5be5006f8026,e43973a9-9d5a-4138-9181-a08a0fc55e2f,8fcf46ef-4a34-480b-a8ee-b0a30a4d3e59"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to keep e43973a9-9d5a-4138-9181-a08a0fc55e2f? For the sake of release branches?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we don’t want to remove the docker images for the release branch just yet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify: another reason that we don't want to remove previous tag because there might be PRs (which are not rebased on top of this) using those dockers?

@malfet malfet requested a review from seemethere April 14, 2020 16:43
@malfet
Copy link
Contributor

malfet commented Apr 14, 2020

@seemethere can you give it a glance as well?

seemethere
seemethere reviewed Apr 14, 2020
View reviewed changes
Copy link
Member

@seemethere seemethere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not seeing where the bionic image is defined here. I see a lot of references to it but I’m failing to see the Dockerfile

@ailzhang
Copy link
Contributor Author

@seemethere It's reusing the exisiting Dockerfile https://github.com/pytorch/pytorch/blob/master/.circleci/docker/ubuntu/Dockerfile#L1.

@seemethere
Copy link
Member

Oh I see, the build.sh magically pulls the ubuntu version out of the image name.

That's... interesting.

@facebook-github-bot
Copy link
Contributor

@ailzhang merged this pull request in 8a60d8b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@ezyang ezyang ezyang approved these changes

@seemethere seemethere seemethere approved these changes

@malfet malfet malfet approved these changes

Assignees
No one assigned
Labels
Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ailzhang @malfet @seemethere @facebook-github-bot @ezyang @mruberry