Add search bar #132
Merged
Add search bar #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for infallible-bhabha-cf3724 ready! Built with commit fb8f584 https://deploy-preview-132--infallible-bhabha-cf3724.netlify.com |
|
@Pat878 is there any way to improve the way longer search terms wrap in the left column of the search results dropdown? For example, can we try wrapping it after a "." rather than after a set number of characters? Or is it possible to widen the left column of the search results dropdown more so that most terms will fit without wrapping? |
|
Merging as-is to meet tomorrow's release timeline, but would be great to address the left column width / behavior as a fast-follow. cc @Pat878 @JoelMarcey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a search bar to the nav section of the site. I used @JoelMarcey's
add-search-boxbranch as a starting point for the design changes.