Skip to content

Moving Site Deployment script to GHA #1415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Aug 10, 2023
Merged

Moving Site Deployment script to GHA #1415

merged 27 commits into from
Aug 10, 2023

Conversation

osalpekar
Copy link
Member

@osalpekar osalpekar commented Jul 25, 2023 •
edited
Loading

We are moving all jobs to GHA across the PyTorch organization. This PR does this for the site deployment CCI job that exists in the pytorch.github.io repo. Note that this does not use caching in its current form - we can likely do this in a follow-up.

WIP: testing this without breaking anything

cc @atalman @svekars

@netlify
Copy link

netlify bot commented Jul 25, 2023 •
edited
Loading

👷 Deploy Preview for pytorch-dot-org-preview processing.

Name Link
🔨 Latest commit 8de1c0c
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-dot-org-preview/deploys/64d55b4f31722f0007a0c5dc

@atalman
Copy link
Contributor

atalman commented Jul 26, 2023

We should also add deprecation of circleci workflow: https://github.com/pytorch/pytorch.github.io/blob/site/.circleci/config.yml

atalman
atalman approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@osalpekar osalpekar merged commit 995cacb into pytorch:site Aug 10, 2023
@cjyabraham
Copy link
Collaborator

cjyabraham commented Aug 11, 2023 •
edited
Loading

Hi @osalpekar, I've deployed a change to the PyTorch website but it is not building as expected. Any ideas why?

@osalpekar
Copy link
Member Author

Looks like the push is still failing for GHA job on trunk, which is why the site is not getting built as expected. I'm going to bring back the CCI job temporarily until we can figure out the GHA issue.

cc @atalman

@malfet
Copy link
Contributor

malfet commented Aug 12, 2023

@osalpekar when you did the migration, have you added the secrets to the workflow?

@osalpekar
Copy link
Member Author

@malfet Yes, that's done here: https://github.com/pytorch/pytorch.github.io/blob/site/.github/workflows/build.yml#L16.

@malfet
Copy link
Contributor

malfet commented Aug 12, 2023

I remember seeing something like that in the past. Will push the fix once find out what was it

@malfet
Copy link
Contributor

malfet commented Aug 12, 2023

Ok, two things were missing:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atalman atalman atalman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@osalpekar @atalman @cjyabraham @malfet