fix missing import os for ddp #1490
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for pytorch-dot-org-preview processing.
|
|
Thank you for the fix, but this file is automatically generated, we should add it to https://github.com/pytorch/pytorch/blob/main/docs/source/notes/ddp.rst (added pytorch/pytorch#111833 mentioning this issue) |
malfet
added a commit
to pytorch/pytorch
that referenced
this pull request
Oct 23, 2023
To include `import os` otherwise sample is not syntactically correct Reported in pytorch/pytorch.github.io#1490
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Oct 23, 2023
To include `import os` otherwise sample is not syntactically correct Reported in pytorch/pytorch.github.io#1490 Pull Request resolved: #111833 Approved by: https://github.com/wanchaol
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
To include `import os` otherwise sample is not syntactically correct Reported in pytorch/pytorch.github.io#1490 Pull Request resolved: pytorch#111833 Approved by: https://github.com/wanchaol
|
ok, thank you @malfet |
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
To include `import os` otherwise sample is not syntactically correct Reported in pytorch/pytorch.github.io#1490 Pull Request resolved: pytorch#111833 Approved by: https://github.com/wanchaol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.