Skip to content

Reactivate Hello Bar #1938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 19, 2025
Merged

Reactivate Hello Bar #1938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
698f4ee
Reactivate Hello Bar
cjyabraham Mar 16, 2025
22462d6
Merge branch 'site' into 3-16a
cjyabraham Mar 17, 2025
20e928f
Merge branch 'site' into 3-16a
cjyabraham Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion _includes/header.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div class="hello-bar">
<div class="container">
Join us in Silicon Valley September 18-19 at the 2024 PyTorch Conference. <a target="_blank" href="https://events.linuxfoundation.org/pytorch-conference/?utm_source=www&utm_medium=homepage&utm_campaign=Pytorch-Conference-2024&utm_content=hello">Learn more</a>.
Join us at PyTorch Conference in San Francisco, October 22-23. CFP open now! <a target="_blank" href="https://events.linuxfoundation.org/pytorch-conference/">Learn more</a>.
</div>
</div>
<div class="container-fluid header-holder {{ page.body-class }}-header">
Expand Down
2 changes: 1 addition & 1 deletion _layouts/blog_detail.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<div class="main-background blog-background blog-detail-background"></div>
<div class="hello-bar">
<div class="container">
Join us in Silicon Valley September 18-19 at the 2024 PyTorch Conference. <a target="_blank" href="https://events.linuxfoundation.org/pytorch-conference/">Learn more</a>.
Join us at PyTorch Conference in San Francisco, October 22-23. CFP open now! <a target="_blank" href="https://events.linuxfoundation.org/pytorch-conference/">Learn more</a>.
</div>
</div>

Expand Down
7 changes: 5 additions & 2 deletions _sass/navigation.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
height: $mobile_header_height;

@include full-nav-menu-desktop {
height: $desktop_header_height;
height: $desktop_header_height - 20px;
}

align-items: center;
Expand All @@ -13,6 +13,9 @@
position: fixed;
right: 0;
top: 0;
@include full-nav-menu-desktop {
top: 32px;
}
width: 100%;
z-index: 9999;

Expand All @@ -36,7 +39,7 @@
@include full-nav-menu-desktop {
background-color: #CC2F90;
color: $white;
display: none;
display: flex;
letter-spacing: .34px;
justify-content: center;
padding: 4px 0;
Expand Down