Skip to content

remove conda references from markdown for install UI #2010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: site
Choose a base branch
from

Conversation

Camyll
Copy link
Collaborator

@Camyll Camyll commented Apr 30, 2025

Remove conda references on installation guidance on pytorch site such as:
image

https://pytorch.org/get-started/locally/#windows-anaconda

Copy link

netlify bot commented Apr 30, 2025

Deploy Preview for pytorch-dot-org-preview ready!

Name Link
🔨 Latest commit 106b092
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-dot-org-preview/deploys/6812941593c0d9000839e909
😎 Deploy Preview https://deploy-preview-2010--pytorch-dot-org-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Camyll Camyll marked this pull request as ready for review April 30, 2025 20:38
@Camyll Camyll requested review from malfet, huydhn, ZainRizvi, atalman, clee2000 and yangw-dev and removed request for huydhn April 30, 2025 20:38
@Camyll Camyll marked this pull request as draft April 30, 2025 20:41
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Camyll Camyll requested a review from svekars April 30, 2025 20:52
@@ -91,7 +71,7 @@ For the majority of PyTorch users, installing from a pre-built binary via a pack
### Prerequisites
{: #mac-prerequisites-2}

1. [Optional] Install [Anaconda](#anaconda)
1. [Optional] Install [pip](https://pypi.org/project/pip/)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replaced this with pip but is this correct or should we remove step 1 since it's optional?

@Camyll
Copy link
Collaborator Author

Camyll commented Apr 30, 2025

image image

@Camyll Camyll marked this pull request as ready for review April 30, 2025 21:14
### pip
{: #mac-pip}

To install PyTorch via pip, use one of the following two commands, depending on your Python version:
To install PyTorch via pip, use the following the command, depending on your Python version:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correcting language here - not relevant to this PR though so I can remove it if we want to do that another time. There's only one command under here though

### pip
{: #mac-pip}

To install PyTorch via pip, use one of the following two commands, depending on your Python version:
To install PyTorch via pip, use the following the command, depending on your Python version:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To install PyTorch via pip, use the following the command, depending on your Python version:
To install PyTorch via pip, use the following command, depending on your Python version:

@@ -1,7 +1,7 @@
# Installing on macOS
{:.no_toc}

PyTorch can be installed and used on macOS. Depending on your system and GPU capabilities, your experience with PyTorch on a Mac may vary in terms of processing time.
PyTorch can be installed and used on macOS. Depending on your system and GPU capabilities, your experience with PyTorch on a Mac may vary in terms of processing time.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PyTorch can be installed and used on macOS. Depending on your system and GPU capabilities, your experience with PyTorch on a Mac may vary in terms of processing time.
PyTorch can be installed and used on macOS. Depending on your system and GPU capabilities, your experience with PyTorch on macOS may vary in terms of processing time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants