Fix 404 on pages with trailing slashes #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned on Jekyll 2->3 migration guide, certain URLs with trailing slashes return 404.
For example,
https://pytorch.org/hub works, but https://pytorch.org/hub/ doesn't
I think that one of the solution is add trailing slashes in the
permalink, the other is to rename files toindex.htmle.g. inhub/folder renamehub.htmltoindex.html.This PR adds trailing slashes, but doing so will break the link https://pytorch.org/hub.html. I don't think it'll cause any problem as all the URLs in this repo use
/hub.