Skip to content

Design changes #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Design changes #50

wants to merge 5 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 8, 2018

  • colors
    fix color inconsistency
    improve color contrast
  • html tags
    fix h1, h2... tag font sizes
    fix header-paragraph style relation
  • images
    remake static logos
    optimize images
    add Github and Twitter logos
  • general
    clean up unused styles
    fix formatting
    fix main.css-bootstrap conflicts

@soumith
Copy link
Member

soumith commented Sep 8, 2018

@iinfin can you give me context on why you are sending in these changes?
We also have a massive site redesign in-flight (landing in next 2 weeks), and your changes will likely conflict with that.

@ghost
Copy link
Author

ghost commented Sep 9, 2018

@soumith I didn't know you were willing to make a complete redesign, happy to hear that. I'm a designer and I'd like to propose some concepts if it's okay.

In this PR, I didn't change the overall design, fixed many misused cases, like h3 was used for title, font size edited to ~45 and then h1 used for paragraph font size edited to 14 etc.
I also remade logos, their sizes varied a lot and you used classes to resize/fit them into logo table.

Here's a screen shot, with slight color, font, and grid improvements on front.

pytorch

@ghost
Copy link
Author

ghost commented Sep 9, 2018

@soumith Here's a quick concept sketch I made.

about

about

menu

menu

@soumith
Copy link
Member

soumith commented Sep 9, 2018

hey han. you should wait till next Sunday, the new website will go live.

@soumith
Copy link
Member

soumith commented Sep 9, 2018

it's a big revamp, and looks nothing like the existing site.

@ghost
Copy link
Author

ghost commented Sep 9, 2018

@soumith alright then I'm closing the PR, I'll see if there's something for me to contribute after the redesign.

@ghost ghost closed this Sep 9, 2018
JoelMarcey pushed a commit that referenced this pull request Sep 19, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants