Skip to content

Remove unused fields from RawDecodedOutput struct #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 21, 2025

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Jan 20, 2025

These don'tseem to be used anywhere. If tests are green, we may want to consider renaming RawDecodedOutput to something more descriptive. At this point it's just an AVFrame and a stream index.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jan 20, 2025
@NicolasHug NicolasHug changed the title Remove unused data field from RawDecodedOutput Remove unused fields from RawDecodedOutput struct Jan 20, 2025
@scotts
Copy link
Contributor

scotts commented Jan 21, 2025

Agreed with the principle of simplification and better naming.

@NicolasHug NicolasHug merged commit ef26284 into pytorch:main Jan 21, 2025
44 of 47 checks passed
NicolasHug added a commit to NicolasHug/torchcodec that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants